[Intel-xe] ✗ CI.checkpatch: warning for Intel_fb.c refactoring

Patchwork patchwork at emeril.freedesktop.org
Fri Nov 17 23:14:23 UTC 2023


== Series Details ==

Series: Intel_fb.c refactoring
URL   : https://patchwork.freedesktop.org/series/126505/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
63c2b6b160bca2df6efc7bc4cea6f442097d7854
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 1fbd84d9a2e1234a0b6e1fcbc75f7f2289827a4b
Author: Jouni Högander <jouni.hogander at intel.com>
Date:   Thu Nov 16 08:41:45 2023 +0200

    fixup! drm/xe/display: Implement display support
    
    Add Xe specific code for intel_fb.c
    
    Signed-off-by: Jouni Högander <jouni.hogander at intel.com>
+ /mt/dim checkpatch 3b8183b7efad3d97ab6cf401f3fc0d24b30b6d3d drm-intel
faa51e1db fixup! FIXME: drm/i915/display: Remaining changes to make xe compile
8ad53e087 Revert "FIXME: drm/i915: xe intel_fb.c framebuffer init and destroy xe changes"
-:10: WARNING:UNKNOWN_COMMIT_ID: Unknown commit id '14d1d786caacdb3438d07ab86fabf2e36c8151cc', maybe rebased or not pulled?
#10: 
This reverts commit 14d1d786caacdb3438d07ab86fabf2e36c8151cc.

total: 0 errors, 1 warnings, 0 checks, 27 lines checked
cc7dfa8c4 fixup! drm/xe/display: Implement display support
-:33: CHECK:BRACES: braces {} should be used on all arms of this statement
#33: FILE: drivers/gpu/drm/xe/compat-i915-headers/gem/i915_gem_object_frontbuffer.h:18:
+	if (!front) {
[...]
+	} else
[...]

-:41: CHECK:BRACES: Unbalanced braces around else statement
#41: FILE: drivers/gpu/drm/xe/compat-i915-headers/gem/i915_gem_object_frontbuffer.h:26:
+	} else

total: 0 errors, 0 warnings, 2 checks, 27 lines checked
8ccd953fc fixup! drm/xe/display: Implement display support
1864bf27a drm/i915/display: use intel_bo_to_drm_bo in intel_fb.c
f9f0d1f2f drm/i915/display: Convert intel_fb_modifier_to_tiling as non-static
c38e4f827 drm/i915/display: Split i915 specific code away from intel_fb.c
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:144: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#144: 
new file mode 100644

-:149: WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'drivers/gpu/drm/i915/display/intel_fb_bo.c', please use '//' instead
#149: FILE: drivers/gpu/drm/i915/display/intel_fb_bo.c:1:
+/* SPDX-License-Identifier: MIT */

-:149: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#149: FILE: drivers/gpu/drm/i915/display/intel_fb_bo.c:1:
+/* SPDX-License-Identifier: MIT */

total: 0 errors, 3 warnings, 0 checks, 229 lines checked
1fbd84d9a fixup! drm/xe/display: Implement display support
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:26: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#26: 
new file mode 100644

-:31: WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'drivers/gpu/drm/xe/display/intel_fb_bo.c', please use '//' instead
#31: FILE: drivers/gpu/drm/xe/display/intel_fb_bo.c:1:
+/* SPDX-License-Identifier: MIT */

-:31: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#31: FILE: drivers/gpu/drm/xe/display/intel_fb_bo.c:1:
+/* SPDX-License-Identifier: MIT */

-:73: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#73: FILE: drivers/gpu/drm/xe/display/intel_fb_bo.c:43:
+intel_fb_bo_lookup_valid_bo(struct drm_i915_private *i915,
+			 struct drm_file *filp,

total: 0 errors, 3 warnings, 1 checks, 92 lines checked




More information about the Intel-xe mailing list