[Intel-xe] ✓ CI.checkpatch: success for drm/xe/guc: Use FAST_REQUEST for non-blocking H2G messages (rev2)

Patchwork patchwork at emeril.freedesktop.org
Mon Nov 20 09:33:37 UTC 2023


== Series Details ==

Series: drm/xe/guc: Use FAST_REQUEST for non-blocking H2G messages (rev2)
URL   : https://patchwork.freedesktop.org/series/126495/
State : success

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
63c2b6b160bca2df6efc7bc4cea6f442097d7854
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit f07aeca2c07f6ebadc1668a98711672ae81ac6ea
Author: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
Date:   Thu Nov 16 14:16:37 2023 -0800

    drm/xe/guc: Use FAST_REQUEST for non-blocking H2G messages
    
    We're currently sending non-blocking H2G messages using the EVENT type,
    which suppresses all CTB protocol replies from the GuC, including the
    failure cases. This might cause errors to slip through and manifest as
    unexpected behavior (e.g. a context state might not be what the driver
    thinks it is because the state change command was silently rejected by
    the GuC). To avoid this kind of problems, we can use the FAST_REQUEST
    type instead, which suppresses the reply only on success; this way we
    still get the advantage of not having to wait for an ack from the GuC
    (i.e. the H2G is still non-blocking) while still detecting errors.
    Since we can't escalate to the caller when a non-blocking message
    fails, we need to escalate to GT reset instead.
    
    Note that FAST_REQUEST failures are NOT expected and are usually a sign
    that the H2G was either malformed or requested an illegal operation.
    
    v2: assign fence values to FAST_REQUEST messages, fix abi doc, use xe_gt
    printers (Michal).
    
    Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
    Cc: John Harrison <John.C.Harrison at Intel.com>
    Cc: Matthew Brost <matthew.brost at intel.com>
    Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
+ /mt/dim checkpatch b25aa17bffa88c86fec716e40bdb3848eea17b23 drm-intel
f07aeca2c drm/xe/guc: Use FAST_REQUEST for non-blocking H2G messages




More information about the Intel-xe mailing list