[Intel-xe] [PATCH] fixup! drm/xe: Moving and renaming existing frequency sysfs attributes

[Lucas De Marchi]

On Tue, Nov 21, 2023 at 11:45:04AM -0600, Lucas De Marchi wrote:
>On Mon, Nov 20, 2023 at 08:08:52PM -0800, Ashutosh Dixit wrote:
>>Actually: Revert "drm/xe: Moving and renaming existing frequency sysfs attributes"
>>
>>This reverts commit c2785fa716b862203a640564a849377d4d8470f5.
>>
>>The commit is badly broken. Allow the author to fix and resubmit.
>>
>>$ cat /sys/class/drm/card0/device/tile0/gt0/freq/min_freq
>>Segmentation fault
>>
>>In dmesg:
>>
>>[  786.327812] general protection fault, probably for non-canonical address 0xcccccccccccccccc: 0000 [#3] PREEMPT SMP NOPTI
>>[  786.327840] CPU: 13 PID: 2267 Comm: cat Tainted: G      D    O       6.6.0-rc3+ #15
>>[  786.327853] Hardware name: Intel Corporation Raptor Lake Client Platform/RaptorLake-P DDR5 RVP, BIOS RPLPFWI1.R00.4221.A00.2305271351 05/27/2023
>>[  786.327868] RIP: 0010:min_freq_show+0x15/0x120 [xe]
>>[  786.327973] RSP: 0018:ffffc9000481fdb8 EFLAGS: 00010282
>>[  786.327984] RAX: ffffffffa017aee0 RBX: cccccccccccccccc RCX: 0000000000000000
>>[  786.327994] RDX: ffff888147209000 RSI: ffffffffa02c3da0 RDI: ffff888103f2af40
>>[  786.328003] RBP: ffff888147209000 R08: 0000000000000001 R09: 0000000000000000
>>[  786.328013] R10: ffffc9000481fdf0 R11: ffffffff8147d0e2 R12: ffff888103f2af40
>>[  786.328022] R13: ffff888108df6800 R14: ffff88813d668e48 R15: 0000000000000001
>>[  786.328031] FS:  00007f8a5a4db740(0000) GS:ffff88906f880000(0000) knlGS:0000000000000000
>>[  786.328043] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
>>[  786.328051] CR2: 00007f8a5a462000 CR3: 000000013d85c000 CR4: 0000000000f50ee0
>>[  786.328061] PKRU: 55555554
>>[  786.328066] Call Trace:
>>[  786.328072]  <TASK>
>>[  786.328077]  ? die_addr+0x32/0x90
>>[  786.328090]  ? exc_general_protection+0x1a5/0x3f0
>>[  786.328104]  ? asm_exc_general_protection+0x26/0x30
>>[  786.328118]  ? kernfs_seq_start+0x22/0x110
>>[  786.328130]  ? __pfx_min_freq_show+0x10/0x10 [xe]
>>[  786.328189]  ? min_freq_show+0x15/0x120 [xe]
>>[  786.328241]  sysfs_kf_seq_show+0xb5/0x100
>>[  786.328252]  seq_read_iter+0x111/0x4c0
>>[  786.328264]  vfs_read+0x1c7/0x330
>>[  786.328276]  ksys_read+0x64/0xe0
>>[  786.328285]  do_syscall_64+0x3c/0x90
>>[  786.328293]  entry_SYSCALL_64_after_hwframe+0x6e/0xd8
>>
>>Signed-off-by: Ashutosh Dixit <ashutosh.dixit at intel.com>
>
>
>Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>
>
>do we also need to revert anything in igt?

answering my own question... From igt, tests/intel/xe_guc_pc.c,
functions get_freq() and set_freq(), it seems  it never got the rename.
I don't see anything pending in the igt mailing list neither.

Let's revert and try to merge both close together next time.

Applied to drm-xe-next, thanks.

Lucas De Marchi

>
>Lucas De Marchi