[Intel-xe] ✗ CI.checkpatch: warning for series starting with [1/4] drm: Add drm_vblank_work_flush_all().

Patchwork patchwork at emeril.freedesktop.org
Wed Nov 22 06:48:57 UTC 2023


== Series Details ==

Series: series starting with [1/4] drm: Add drm_vblank_work_flush_all().
URL   : https://patchwork.freedesktop.org/series/126715/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
63c2b6b160bca2df6efc7bc4cea6f442097d7854
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 73c18e311b46f8aface54668cd3d31b21bdc5bc1
Author: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
Date:   Tue Nov 21 15:05:02 2023 +0100

    drm/i915: Use the same vblank worker for atomic unpin
    
    In case of legacy cursor update, the cursor VMA needs to be unpinned
    only after vblank. This exceeds the lifetime of the whole atomic commit.
    
    Any trick I attempted to keep the atomic commit alive didn't work, as
    drm_atomic_helper_setup_commit() force throttles on any old commit that
    wasn't cleaned up.
    
    The only option remaining is to remove the plane from the atomic commit,
    and use the same path as the legacy cursor update to clean the state
    after vblank.
    
    Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
+ /mt/dim checkpatch 89e2bb1e155242dd9aa46bc90e563e71c5f498b0 drm-intel
cc92fb9ce drm: Add drm_vblank_work_flush_all().
-:33: WARNING:WAITQUEUE_ACTIVE: waitqueue_active without comment
#33: FILE: drivers/gpu/drm/drm_vblank_work.c:246:
+			    waitqueue_active(&vblank->work_wait_queue),

total: 0 errors, 1 warnings, 0 checks, 41 lines checked
5a0f83592 drm/xe/display: Cache pinned ggtt_vma's.
3d029049f drm/i915: Use vblank worker to unpin old legacy cursor fb safely
73c18e311 drm/i915: Use the same vblank worker for atomic unpin
-:46: WARNING:TYPO_SPELLING: 'succesful' may be misspelled - perhaps 'successful'?
#46: FILE: drivers/gpu/drm/i915/display/intel_atomic_plane.c:1168:
+	 * This branch can only ever be called after plane update is succesful,
 	                                                             ^^^^^^^^^

-:127: WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#127: FILE: drivers/gpu/drm/i915/display/intel_crtc.c:746:
+							 drm_crtc_accurate_vblank_count(&crtc->base) + 1,

total: 0 errors, 2 warnings, 0 checks, 118 lines checked




More information about the Intel-xe mailing list