[Intel-xe] ✗ CI.checkpatch: warning for series starting with [1/2] drm/xe: Remove XE_PVC_XT_IDS

Patchwork patchwork at emeril.freedesktop.org
Wed Nov 22 07:36:29 UTC 2023


== Series Details ==

Series: series starting with [1/2] drm/xe: Remove XE_PVC_XT_IDS
URL   : https://patchwork.freedesktop.org/series/126727/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
63c2b6b160bca2df6efc7bc4cea6f442097d7854
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit e134a88699b89e753b3be0c540e79f769c874ced
Author: Lucas De Marchi <lucas.demarchi at intel.com>
Date:   Tue Nov 21 11:52:09 2023 -0800

    drm/xe: Sync MTL PCI IDs with i915
    
    For Xe1 platforms, it's better to follow the way i915 adds the PCI IDs
    to the header, so it's easier to catch up when there is an update. This
    brings the same logic applied in commit 2e3c369f23a7 ("drm/i915/mtl:
    Eliminate subplatforms") to the equivalent xe header.
    
    The end result of this header for Xe1 platforms is now in sync with i915
    as of commit 5032c607e886 ("drm/i915: ATS-M device ID update"). This can
    be seen by
    
            $ git show 5032c607e886:include/drm/i915_pciids.h > a.h
            $ git diff --color-words  --no-index a.h include/drm/xe_pciids.h
    
    Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
+ /mt/dim checkpatch 89e2bb1e155242dd9aa46bc90e563e71c5f498b0 drm-intel
b288e1a99 drm/xe: Remove XE_PVC_XT_IDS
-:19: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#19: FILE: include/drm/xe_pciids.h:177:
+#define XE_PVC_IDS(MACRO__, ...)		\
 	MACRO__(0x0B69, ## __VA_ARGS__),	\
 	MACRO__(0x0B6E, ## __VA_ARGS__),	\
 	MACRO__(0x0BD5, ## __VA_ARGS__),	\

-:19: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'MACRO__' - possible side-effects?
#19: FILE: include/drm/xe_pciids.h:177:
+#define XE_PVC_IDS(MACRO__, ...)		\
 	MACRO__(0x0B69, ## __VA_ARGS__),	\
 	MACRO__(0x0B6E, ## __VA_ARGS__),	\
 	MACRO__(0x0BD5, ## __VA_ARGS__),	\

total: 1 errors, 0 warnings, 1 checks, 17 lines checked
e134a8869 drm/xe: Sync MTL PCI IDs with i915
-:8: WARNING:UNKNOWN_COMMIT_ID: Unknown commit id '2e3c369f23a7', maybe rebased or not pulled?
#8: 
brings the same logic applied in commit 2e3c369f23a7 ("drm/i915/mtl:

-:12: WARNING:UNKNOWN_COMMIT_ID: Unknown commit id '5032c607e886', maybe rebased or not pulled?
#12: 
as of commit 5032c607e886 ("drm/i915: ATS-M device ID update"). This can

-:29: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#29: FILE: include/drm/xe_pciids.h:177:
+#define XE_MTL_IDS(MACRO__, ...)		\
+	MACRO__(0x7D40, ## __VA_ARGS__),	\
+	MACRO__(0x7D45, ## __VA_ARGS__),	\
+	MACRO__(0x7D55, ## __VA_ARGS__),	\
+	MACRO__(0x7D60, ## __VA_ARGS__),	\
+	MACRO__(0x7D67, ## __VA_ARGS__),	\
+	MACRO__(0x7DD5, ## __VA_ARGS__)

-:29: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'MACRO__' - possible side-effects?
#29: FILE: include/drm/xe_pciids.h:177:
+#define XE_MTL_IDS(MACRO__, ...)		\
+	MACRO__(0x7D40, ## __VA_ARGS__),	\
+	MACRO__(0x7D45, ## __VA_ARGS__),	\
+	MACRO__(0x7D55, ## __VA_ARGS__),	\
+	MACRO__(0x7D60, ## __VA_ARGS__),	\
+	MACRO__(0x7D67, ## __VA_ARGS__),	\
+	MACRO__(0x7DD5, ## __VA_ARGS__)

total: 1 errors, 2 warnings, 1 checks, 49 lines checked




More information about the Intel-xe mailing list