[Intel-xe] [RFC v2 1/6] drm/xe/xe2: Support flat ccs.

Ghimiray, Himal Prasad himal.prasad.ghimiray at intel.com
Mon Nov 27 03:04:35 UTC 2023


Hi Matthew,

On 23-11-2023 21:58, Matthew Auld wrote:
> On Tue, 21 Nov 2023 at 10:01, Himal Prasad Ghimiray
> <himal.prasad.ghimiray at intel.com> wrote:
>> Enable flat ccs for XE2_GFX_FEATURES.
>>
>> Cc: Thomas Hellström <thomas.hellstrom at linux.intel.com>
>> Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray at intel.com>
> I guess this should rather be the final patch in the series, once we
> have it working?

Thanks for the review. Will move this patch as final patch in next version.

>> ---
>>   drivers/gpu/drm/xe/xe_pci.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
>> index 682ba188e456..d9754f3d45f7 100644
>> --- a/drivers/gpu/drm/xe/xe_pci.c
>> +++ b/drivers/gpu/drm/xe/xe_pci.c
>> @@ -157,7 +157,7 @@ static const struct xe_graphics_desc graphics_xelpg = {
>>   #define XE2_GFX_FEATURES \
>>          .dma_mask_size = 46, \
>>          .has_asid = 1, \
>> -       .has_flat_ccs = 0 /* FIXME: implementation missing */, \
>> +       .has_flat_ccs = 1, \
>>          .has_range_tlb_invalidation = 1, \
>>          .supports_usm = 0 /* FIXME: implementation missing */, \
>>          .va_bits = 48, \
>> --
>> 2.25.1
>>


More information about the Intel-xe mailing list