[Intel-xe] [PATCH] drm/xe/dg2: Drop Wa_22014600077

Gustavo Sousa gustavo.sousa at intel.com
Mon Nov 27 20:45:00 UTC 2023


Quoting Gustavo Sousa (2023-11-27 17:39:23-03:00)
>Quoting Matt Roper (2023-11-27 16:03:33-03:00)
>>The workaround database has been updated to drop this workaround for all
>>DG2 variants.
>>
>>Signed-off-by: Matt Roper <matthew.d.roper at intel.com>
>>---
>> drivers/gpu/drm/xe/xe_wa.c | 21 ---------------------
>> 1 file changed, 21 deletions(-)
>>
>>diff --git a/drivers/gpu/drm/xe/xe_wa.c b/drivers/gpu/drm/xe/xe_wa.c
>>index 81ae0232146e..e0853ab30c00 100644
>>--- a/drivers/gpu/drm/xe/xe_wa.c
>>+++ b/drivers/gpu/drm/xe/xe_wa.c
>>@@ -522,27 +522,6 @@ static const struct xe_rtp_entry_sr engine_was[] = {
>>           XE_RTP_ACTIONS(SET(HALF_SLICE_CHICKEN7,
>>                              DG2_DISABLE_ROUND_ENABLE_ALLOW_FOR_SSLA))
>>         },
>>-        { XE_RTP_NAME("22014600077"),
>>-          XE_RTP_RULES(SUBPLATFORM(DG2, G11), GRAPHICS_STEP(B0, FOREVER),
>>-                       ENGINE_CLASS(RENDER)),
>>-          XE_RTP_ACTIONS(SET(CACHE_MODE_SS,
>>-                             ENABLE_EU_COUNT_FOR_TDL_FLUSH,
>
>ENABLE_EU_COUNT_FOR_TDL_FLUSH gets unused after this change. With the removal of

Hm, after reviewing the i915 version of this patch... Looks like we are missing
some workarounds from Xe_LPG?

--
Gustavo Sousa

>its definition,
>
>Reviewed-by: Gustavo Sousa <gustavo.sousa at intel.com>
>
>>-                             /*
>>-                              * Wa_14012342262 write-only reg, so skip
>>-                              * verification
>>-                              */
>>-                             .read_mask = 0))
>>-        },
>>-        { XE_RTP_NAME("22014600077"),
>>-          XE_RTP_RULES(SUBPLATFORM(DG2, G10), ENGINE_CLASS(RENDER)),
>>-          XE_RTP_ACTIONS(SET(CACHE_MODE_SS,
>>-                             ENABLE_EU_COUNT_FOR_TDL_FLUSH,
>>-                             /*
>>-                              * Wa_14012342262 write-only reg, so skip
>>-                              * verification
>>-                              */
>>-                             .read_mask = 0))
>>-        },
>>         { XE_RTP_NAME("14015150844"),
>>           XE_RTP_RULES(PLATFORM(DG2), FUNC(xe_rtp_match_first_render_or_compute)),
>>           XE_RTP_ACTIONS(SET(XEHP_HDC_CHICKEN0, DIS_ATOMIC_CHAINING_TYPED_WRITES,
>>-- 
>>2.41.0
>>


More information about the Intel-xe mailing list