[Intel-xe] [PATCH V3 1/3] drm/xe: Track if platform has csc uid

[Michal Wajdeczko]

On 28.11.2023 16:13, Tejas Upadhyay wrote:
> Some platforms, like ATS-M has CSC firmware calculated unique

what is "CSC firmware" ? maybe just:

"On some platforms, like ATS-M, we can expose firmware calculated Unique
Identifier (UID) of the device."

> device id. This flag will help to identify if platform has it.
> 
> V2:
>   - Rebase to resolve pre-merge conflict
> 
> Signed-off-by: Tejas Upadhyay <tejas.upadhyay at intel.com>
> ---
>  drivers/gpu/drm/xe/xe_device_types.h | 2 ++
>  drivers/gpu/drm/xe/xe_pci.c          | 3 +++
>  2 files changed, 5 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_device_types.h b/drivers/gpu/drm/xe/xe_device_types.h
> index 2712905c7a91..268a40639ec5 100644
> --- a/drivers/gpu/drm/xe/xe_device_types.h
> +++ b/drivers/gpu/drm/xe/xe_device_types.h
> @@ -264,6 +264,8 @@ struct xe_device {
>  		u8 supports_mmio_ext:1;
>  		/** @has_heci_gscfi: device has heci gscfi */
>  		u8 has_heci_gscfi:1;
> +		/** @has_csc_uid: device has CSC FW calculated uid, used for generating uuid */

if we don't know/care about CSC FW then maybe just ".has_uid" ?

> +		u8 has_csc_uid:1;

keep ordered by name

>  
>  #if IS_ENABLED(CONFIG_DRM_XE_DISPLAY)
>  		struct {
> diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
> index cb762c11dd0f..cf4f7de5b04e 100644
> --- a/drivers/gpu/drm/xe/xe_pci.c
> +++ b/drivers/gpu/drm/xe/xe_pci.c
> @@ -61,6 +61,7 @@ struct xe_device_desc {
>  	u8 has_heci_gscfi:1;
>  
>  	u8 has_llc:1;
> +	u8 has_csc_uid:1;

ditto

>  	u8 has_sriov:1;
>  	u8 bypass_mtcfg:1;
>  	u8 supports_mmio_ext:1;
> @@ -300,6 +301,7 @@ static const struct xe_device_desc ats_m_desc = {
>  
>  	DG2_FEATURES,
>  	.has_display = false,
> +	.has_csc_uid = true,
>  };
>  
>  static const struct xe_device_desc dg2_desc = {
> @@ -579,6 +581,7 @@ static int xe_info_init(struct xe_device *xe,
>  	xe->info.graphics_name = graphics_desc->name;
>  	xe->info.media_name = media_desc ? media_desc->name : "none";
>  	xe->info.has_llc = desc->has_llc;
> +	xe->info.has_csc_uid = desc->has_csc_uid;

ditto

>  	xe->info.has_sriov = desc->has_sriov;
>  	xe->info.bypass_mtcfg = desc->bypass_mtcfg;
>  	xe->info.supports_mmio_ext = desc->supports_mmio_ext;