[Intel-xe] [PATCH v2 2/5] drm/xe/kunit: Remove handling of XE_TEST_SUBPLATFORM_ANY

Matt Roper matthew.d.roper at intel.com
Wed Nov 29 23:54:31 UTC 2023


On Wed, Nov 29, 2023 at 03:28:04PM -0800, Lucas De Marchi wrote:
> The only user passing XE_TEST_SUBPLATFORM_ANY is
> xe_pci_fake_device_init_any(), but then the function would return
> earlier when handling XE_TEST_PLATFORM_ANY. Platforms without a
> subplatform use XE_SUBPLATFORM_NONE.
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>

I was going to say we should remove the define completely, but I see
that happens in a later patch.  So

Reviewed-by: Matt Roper <matthew.d.roper at intel.com>

> ---
>  drivers/gpu/drm/xe/tests/xe_pci.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/tests/xe_pci.c b/drivers/gpu/drm/xe/tests/xe_pci.c
> index f2cdc9bb4612..3d260edd5849 100644
> --- a/drivers/gpu/drm/xe/tests/xe_pci.c
> +++ b/drivers/gpu/drm/xe/tests/xe_pci.c
> @@ -128,11 +128,6 @@ int xe_pci_fake_device_init(struct xe_device *xe, enum xe_platform platform,
>  	if (!ent->device)
>  		return -ENODEV;
>  
> -	if (subplatform == XE_TEST_SUBPLATFORM_ANY) {
> -		subplatform_desc = desc->subplatforms;
> -		goto done;
> -	}
> -
>  	for (subplatform_desc = desc->subplatforms;
>  	     subplatform_desc && subplatform_desc->subplatform;
>  	     subplatform_desc++)
> -- 
> 2.40.1
> 

-- 
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation


More information about the Intel-xe mailing list