[Intel-xe] ✗ CI.checkpatch: warning for drm/xe: Probe tweaks and reordering (rev4)

Patchwork patchwork at emeril.freedesktop.org
Thu Nov 30 00:32:33 UTC 2023


== Series Details ==

Series: drm/xe: Probe tweaks and reordering (rev4)
URL   : https://patchwork.freedesktop.org/series/126392/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
6030b24c1386b00de8187b5fb987e283a57b372a
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 111ec9849fe3594b3ee5a49bb8b59a35a5d9fee0
Author: Michał Winiarski <michal.winiarski at intel.com>
Date:   Wed Nov 29 23:35:08 2023 +0100

    drm/xe: Initialize GuC earlier during probe
    
    SR-IOV VF has limited access to MMIO registers. Fortunately, it is able
    to access a curated subset that is needed to initialize the driver by
    communicating with SR-IOV PF using GuC CT.
    Initialize GuC earlier in order to keep the unified probe ordering
    between VF and PF modes.
    
    Signed-off-by: Michał Winiarski <michal.winiarski at intel.com>
+ /mt/dim checkpatch ff1db4de1e4054052fbf99ef307757fd2bc74df5 drm-intel
f08a0f236 drm/xe: Skip calling drm_dev_put on probe error
228cd57a6 drm/xe: Use managed pci_enable_device
171a5d131 drm/xe/irq: Don't call pci_free_irq_vectors
8aae7bcf6 drm/xe: Move xe_set_dma_info outside of MMIO setup
62409106a drm/xe: Move xe_mmio_probe_tiles outside of MMIO setup
00b18bdd6 drm/xe: Split xe_info_init
53115bd2e drm/xe: Introduce xe_tile_init_early and use at earlier point in probe
d20d280ca drm/xe: Map the entire BAR0 and hold onto the initial mapping
980bb735e drm/xe/device: Introduce xe_device_probe_early
-:76: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'xe__' - possible side-effects?
#76: FILE: drivers/gpu/drm/xe/xe_device.h:127:
+#define for_each_remote_tile(tile__, xe__, id__) \
+	for ((id__) = 1; (id__) < (xe__)->info.tile_count; (id__)++) \
+		for_each_if((tile__) = &(xe__)->tiles[(id__)])

-:76: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'id__' - possible side-effects?
#76: FILE: drivers/gpu/drm/xe/xe_device.h:127:
+#define for_each_remote_tile(tile__, xe__, id__) \
+	for ((id__) = 1; (id__) < (xe__)->info.tile_count; (id__)++) \
+		for_each_if((tile__) = &(xe__)->tiles[(id__)])

total: 0 errors, 0 warnings, 2 checks, 160 lines checked
a69123b3b drm/xe: Don't "peek" into GMD_ID
28bafb6b1 drm/xe: Move system memory management init to earlier point in probe
590df3fd7 drm/xe: Move force_wake init to earlier point in probe
e0b6c496d drm/xe: Reorder GGTT init to earlier point in probe
2b0ea5d24 drm/xe: Add a helper for DRM device-lifetime BO create
16670e53a drm/xe/uc: Split xe_uc_fw_init
194c98981 drm/xe/uc: Store firmware binary in system-memory backed BO
6d734d8a2 drm/xe/uc: Extract xe_uc_sanitize_reset
93431e3a9 drm/xe/guc: Split GuC params used for "hwconfig" and "post-hwconfig"
a5656a446 drm/managed: Add drmm_release_action
28eef8b93 drm/tests: managed: Add a simple test for drmm_managed_release
6345d882e drm/xe/guc: Allocate GuC data structures in system memory for initial load
d5ec238f8 drm/xe/guc: Move GuC power control init to "post-hwconfig"
111ec9849 drm/xe: Initialize GuC earlier during probe




More information about the Intel-xe mailing list