[Intel-xe] [PATCH i-g-t 1/9] lib/kunit: Fix handling of potential errors from F_GETFL
Janusz Krzysztofik
janusz.krzysztofik at linux.intel.com
Tue Oct 3 09:10:46 UTC 2023
Function fcntl(..., F_GETFL, ...) that returns file status flags may also
return a negative error code. Handle that error instead of blindly using
the returned value as flags.
Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik at linux.intel.com>
---
lib/igt_kmod.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c
index d98e6c5f9e..05ff178b27 100644
--- a/lib/igt_kmod.c
+++ b/lib/igt_kmod.c
@@ -783,8 +783,8 @@ static void __igt_kunit(struct igt_ktest *tst, const char *opts)
igt_skip_on_f(tst->kmsg < 0, "Could not open /dev/kmsg\n");
- flags = fcntl(tst->kmsg, F_GETFL, 0) & ~O_NONBLOCK;
- igt_skip_on_f(fcntl(tst->kmsg, F_SETFL, flags) == -1,
+ igt_skip_on((flags = fcntl(tst->kmsg, F_GETFL, 0), flags < 0));
+ igt_skip_on_f(fcntl(tst->kmsg, F_SETFL, flags & ~O_NONBLOCK) == -1,
"Could not set /dev/kmsg to blocking mode\n");
igt_skip_on(lseek(tst->kmsg, 0, SEEK_END) < 0);
--
2.42.0
More information about the Intel-xe
mailing list