[Intel-xe] ✗ CI.checkpatch: warning for xe2: Add PAT programming (rev2)

Patchwork patchwork at emeril.freedesktop.org
Tue Oct 3 13:46:51 UTC 2023 

== Series Details ==

Series: xe2: Add PAT programming (rev2)
URL   : https://patchwork.freedesktop.org/series/124430/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
63c2b6b160bca2df6efc7bc4cea6f442097d7854
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 3731dd04603ebc7a98a2a42f7aa6b2cfeef5e984
Author: Lucas De Marchi <lucas.demarchi at intel.com>
Date:   Tue Oct 3 05:52:17 2023 -0700

    drm/xe/gt: Dump PAT table when failing to initialize
    
    When failing on early initialization, one cause may be that the PAT
    configuration is not correct. Dump it for ease of debugging.
    
    Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
    Reviewed-by: Matt Roper <matthew.d.roper at intel.com>
+ /mt/dim checkpatch 02ab43e36623665d8644d46162bd4ec5eeb68489 drm-intel
248f8b7cc drm/xe/vm: Prefer xe_assert() over XE_WARN_ON()
-:6: WARNING:UNKNOWN_COMMIT_ID: Unknown commit id '99a8844441ba', maybe rebased or not pulled?
#6: 
When xelp_pte_encode_addr() was added in commit 99a8844441ba

total: 0 errors, 1 warnings, 0 checks, 15 lines checked
63ad47d7c drm/xe/xe2: Follow XeHPC for TLB invalidation
af9e24847 fixup! drm/xe/pat: Prefer the arch/IP names
c4c01d2fa drm/xe/xe2: Program PAT tables
-:61: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#61: FILE: drivers/gpu/drm/xe/xe_pat.c:93:
+#define XE2_PAT(no_promote, comp_en, l3clos, l3_policy, l4_policy, coh_mode) \
+	(no_promote ? XE2_NO_PROMOTE : 0) | \
+	(comp_en ? XE2_COMP_EN : 0) | \
+	REG_FIELD_PREP(XE2_L3_CLOS, l3clos) | \
+	REG_FIELD_PREP(XE2_L3_POLICY, l3_policy) | \
+	REG_FIELD_PREP(XE2_L4_POLICY, l4_policy) | \
+	REG_FIELD_PREP(XE2_COH_MODE, coh_mode)

-:70: ERROR:SPACING: space prohibited after that open square bracket '['
#70: FILE: drivers/gpu/drm/xe/xe_pat.c:102:
+	[ 0] = XE2_PAT( 0, 0, 0, 0, 3, 0 ),

-:70: ERROR:SPACING: space prohibited after that open parenthesis '('
#70: FILE: drivers/gpu/drm/xe/xe_pat.c:102:
+	[ 0] = XE2_PAT( 0, 0, 0, 0, 3, 0 ),

-:70: ERROR:SPACING: space prohibited before that close parenthesis ')'
#70: FILE: drivers/gpu/drm/xe/xe_pat.c:102:
+	[ 0] = XE2_PAT( 0, 0, 0, 0, 3, 0 ),

-:71: ERROR:SPACING: space prohibited after that open square bracket '['
#71: FILE: drivers/gpu/drm/xe/xe_pat.c:103:
+	[ 1] = XE2_PAT( 0, 0, 0, 0, 3, 2 ),

-:71: ERROR:SPACING: space prohibited after that open parenthesis '('
#71: FILE: drivers/gpu/drm/xe/xe_pat.c:103:
+	[ 1] = XE2_PAT( 0, 0, 0, 0, 3, 2 ),

-:71: ERROR:SPACING: space prohibited before that close parenthesis ')'
#71: FILE: drivers/gpu/drm/xe/xe_pat.c:103:
+	[ 1] = XE2_PAT( 0, 0, 0, 0, 3, 2 ),

-:72: ERROR:SPACING: space prohibited after that open square bracket '['
#72: FILE: drivers/gpu/drm/xe/xe_pat.c:104:
+	[ 2] = XE2_PAT( 0, 0, 0, 0, 3, 3 ),

-:72: ERROR:SPACING: space prohibited after that open parenthesis '('
#72: FILE: drivers/gpu/drm/xe/xe_pat.c:104:
+	[ 2] = XE2_PAT( 0, 0, 0, 0, 3, 3 ),

-:72: ERROR:SPACING: space prohibited before that close parenthesis ')'
#72: FILE: drivers/gpu/drm/xe/xe_pat.c:104:
+	[ 2] = XE2_PAT( 0, 0, 0, 0, 3, 3 ),

-:73: ERROR:SPACING: space prohibited after that open square bracket '['
#73: FILE: drivers/gpu/drm/xe/xe_pat.c:105:
+	[ 3] = XE2_PAT( 0, 0, 0, 3, 3, 0 ),

-:73: ERROR:SPACING: space prohibited after that open parenthesis '('
#73: FILE: drivers/gpu/drm/xe/xe_pat.c:105:
+	[ 3] = XE2_PAT( 0, 0, 0, 3, 3, 0 ),

-:73: ERROR:SPACING: space prohibited before that close parenthesis ')'
#73: FILE: drivers/gpu/drm/xe/xe_pat.c:105:
+	[ 3] = XE2_PAT( 0, 0, 0, 3, 3, 0 ),

-:74: ERROR:SPACING: space prohibited after that open square bracket '['
#74: FILE: drivers/gpu/drm/xe/xe_pat.c:106:
+	[ 4] = XE2_PAT( 0, 0, 0, 3, 0, 2 ),

-:74: ERROR:SPACING: space prohibited after that open parenthesis '('
#74: FILE: drivers/gpu/drm/xe/xe_pat.c:106:
+	[ 4] = XE2_PAT( 0, 0, 0, 3, 0, 2 ),

-:74: ERROR:SPACING: space prohibited before that close parenthesis ')'
#74: FILE: drivers/gpu/drm/xe/xe_pat.c:106:
+	[ 4] = XE2_PAT( 0, 0, 0, 3, 0, 2 ),

-:75: ERROR:SPACING: space prohibited after that open square bracket '['
#75: FILE: drivers/gpu/drm/xe/xe_pat.c:107:
+	[ 5] = XE2_PAT( 0, 0, 0, 3, 3, 2 ),

-:75: ERROR:SPACING: space prohibited after that open parenthesis '('
#75: FILE: drivers/gpu/drm/xe/xe_pat.c:107:
+	[ 5] = XE2_PAT( 0, 0, 0, 3, 3, 2 ),

-:75: ERROR:SPACING: space prohibited before that close parenthesis ')'
#75: FILE: drivers/gpu/drm/xe/xe_pat.c:107:
+	[ 5] = XE2_PAT( 0, 0, 0, 3, 3, 2 ),

-:76: ERROR:SPACING: space prohibited after that open square bracket '['
#76: FILE: drivers/gpu/drm/xe/xe_pat.c:108:
+	[ 6] = XE2_PAT( 1, 0, 0, 1, 3, 0 ),

-:76: ERROR:SPACING: space prohibited after that open parenthesis '('
#76: FILE: drivers/gpu/drm/xe/xe_pat.c:108:
+	[ 6] = XE2_PAT( 1, 0, 0, 1, 3, 0 ),

-:76: ERROR:SPACING: space prohibited before that close parenthesis ')'
#76: FILE: drivers/gpu/drm/xe/xe_pat.c:108:
+	[ 6] = XE2_PAT( 1, 0, 0, 1, 3, 0 ),

-:77: ERROR:SPACING: space prohibited after that open square bracket '['
#77: FILE: drivers/gpu/drm/xe/xe_pat.c:109:
+	[ 7] = XE2_PAT( 0, 0, 0, 3, 0, 3 ),

-:77: ERROR:SPACING: space prohibited after that open parenthesis '('
#77: FILE: drivers/gpu/drm/xe/xe_pat.c:109:
+	[ 7] = XE2_PAT( 0, 0, 0, 3, 0, 3 ),

-:77: ERROR:SPACING: space prohibited before that close parenthesis ')'
#77: FILE: drivers/gpu/drm/xe/xe_pat.c:109:
+	[ 7] = XE2_PAT( 0, 0, 0, 3, 0, 3 ),

-:78: ERROR:SPACING: space prohibited after that open square bracket '['
#78: FILE: drivers/gpu/drm/xe/xe_pat.c:110:
+	[ 8] = XE2_PAT( 0, 0, 0, 3, 0, 0 ),

-:78: ERROR:SPACING: space prohibited after that open parenthesis '('
#78: FILE: drivers/gpu/drm/xe/xe_pat.c:110:
+	[ 8] = XE2_PAT( 0, 0, 0, 3, 0, 0 ),

-:78: ERROR:SPACING: space prohibited before that close parenthesis ')'
#78: FILE: drivers/gpu/drm/xe/xe_pat.c:110:
+	[ 8] = XE2_PAT( 0, 0, 0, 3, 0, 0 ),

-:79: ERROR:SPACING: space prohibited after that open square bracket '['
#79: FILE: drivers/gpu/drm/xe/xe_pat.c:111:
+	[ 9] = XE2_PAT( 0, 1, 0, 0, 3, 0 ),

-:79: ERROR:SPACING: space prohibited after that open parenthesis '('
#79: FILE: drivers/gpu/drm/xe/xe_pat.c:111:
+	[ 9] = XE2_PAT( 0, 1, 0, 0, 3, 0 ),

-:79: ERROR:SPACING: space prohibited before that close parenthesis ')'
#79: FILE: drivers/gpu/drm/xe/xe_pat.c:111:
+	[ 9] = XE2_PAT( 0, 1, 0, 0, 3, 0 ),

-:80: ERROR:SPACING: space prohibited after that open parenthesis '('
#80: FILE: drivers/gpu/drm/xe/xe_pat.c:112:
+	[10] = XE2_PAT( 0, 1, 0, 3, 0, 0 ),

-:80: ERROR:SPACING: space prohibited before that close parenthesis ')'
#80: FILE: drivers/gpu/drm/xe/xe_pat.c:112:
+	[10] = XE2_PAT( 0, 1, 0, 3, 0, 0 ),

-:81: ERROR:SPACING: space prohibited after that open parenthesis '('
#81: FILE: drivers/gpu/drm/xe/xe_pat.c:113:
+	[11] = XE2_PAT( 1, 1, 0, 1, 3, 0 ),

-:81: ERROR:SPACING: space prohibited before that close parenthesis ')'
#81: FILE: drivers/gpu/drm/xe/xe_pat.c:113:
+	[11] = XE2_PAT( 1, 1, 0, 1, 3, 0 ),

-:82: ERROR:SPACING: space prohibited after that open parenthesis '('
#82: FILE: drivers/gpu/drm/xe/xe_pat.c:114:
+	[12] = XE2_PAT( 0, 1, 0, 3, 3, 0 ),

-:82: ERROR:SPACING: space prohibited before that close parenthesis ')'
#82: FILE: drivers/gpu/drm/xe/xe_pat.c:114:
+	[12] = XE2_PAT( 0, 1, 0, 3, 3, 0 ),

-:83: ERROR:SPACING: space prohibited after that open parenthesis '('
#83: FILE: drivers/gpu/drm/xe/xe_pat.c:115:
+	[13] = XE2_PAT( 0, 0, 0, 0, 0, 0 ),

-:83: ERROR:SPACING: space prohibited before that close parenthesis ')'
#83: FILE: drivers/gpu/drm/xe/xe_pat.c:115:
+	[13] = XE2_PAT( 0, 0, 0, 0, 0, 0 ),

-:84: ERROR:SPACING: space prohibited after that open parenthesis '('
#84: FILE: drivers/gpu/drm/xe/xe_pat.c:116:
+	[14] = XE2_PAT( 0, 1, 0, 0, 0, 0 ),

-:84: ERROR:SPACING: space prohibited before that close parenthesis ')'
#84: FILE: drivers/gpu/drm/xe/xe_pat.c:116:
+	[14] = XE2_PAT( 0, 1, 0, 0, 0, 0 ),

-:85: ERROR:SPACING: space prohibited after that open parenthesis '('
#85: FILE: drivers/gpu/drm/xe/xe_pat.c:117:
+	[15] = XE2_PAT( 1, 1, 0, 1, 1, 0 ),

-:85: ERROR:SPACING: space prohibited before that close parenthesis ')'
#85: FILE: drivers/gpu/drm/xe/xe_pat.c:117:
+	[15] = XE2_PAT( 1, 1, 0, 1, 1, 0 ),

-:87: ERROR:SPACING: space prohibited after that open parenthesis '('
#87: FILE: drivers/gpu/drm/xe/xe_pat.c:119:
+	[20] = XE2_PAT( 0, 0, 1, 0, 3, 0 ),

-:87: ERROR:SPACING: space prohibited before that close parenthesis ')'
#87: FILE: drivers/gpu/drm/xe/xe_pat.c:119:
+	[20] = XE2_PAT( 0, 0, 1, 0, 3, 0 ),

-:88: ERROR:SPACING: space prohibited after that open parenthesis '('
#88: FILE: drivers/gpu/drm/xe/xe_pat.c:120:
+	[21] = XE2_PAT( 0, 1, 1, 0, 3, 0 ),

-:88: ERROR:SPACING: space prohibited before that close parenthesis ')'
#88: FILE: drivers/gpu/drm/xe/xe_pat.c:120:
+	[21] = XE2_PAT( 0, 1, 1, 0, 3, 0 ),

-:89: ERROR:SPACING: space prohibited after that open parenthesis '('
#89: FILE: drivers/gpu/drm/xe/xe_pat.c:121:
+	[22] = XE2_PAT( 0, 0, 1, 0, 3, 2 ),

-:89: ERROR:SPACING: space prohibited before that close parenthesis ')'
#89: FILE: drivers/gpu/drm/xe/xe_pat.c:121:
+	[22] = XE2_PAT( 0, 0, 1, 0, 3, 2 ),

-:90: ERROR:SPACING: space prohibited after that open parenthesis '('
#90: FILE: drivers/gpu/drm/xe/xe_pat.c:122:
+	[23] = XE2_PAT( 0, 0, 1, 0, 3, 3 ),

-:90: ERROR:SPACING: space prohibited before that close parenthesis ')'
#90: FILE: drivers/gpu/drm/xe/xe_pat.c:122:
+	[23] = XE2_PAT( 0, 0, 1, 0, 3, 3 ),

-:91: ERROR:SPACING: space prohibited after that open parenthesis '('
#91: FILE: drivers/gpu/drm/xe/xe_pat.c:123:
+	[24] = XE2_PAT( 0, 0, 2, 0, 3, 0 ),

-:91: ERROR:SPACING: space prohibited before that close parenthesis ')'
#91: FILE: drivers/gpu/drm/xe/xe_pat.c:123:
+	[24] = XE2_PAT( 0, 0, 2, 0, 3, 0 ),

-:92: ERROR:SPACING: space prohibited after that open parenthesis '('
#92: FILE: drivers/gpu/drm/xe/xe_pat.c:124:
+	[25] = XE2_PAT( 0, 1, 2, 0, 3, 0 ),

-:92: ERROR:SPACING: space prohibited before that close parenthesis ')'
#92: FILE: drivers/gpu/drm/xe/xe_pat.c:124:
+	[25] = XE2_PAT( 0, 1, 2, 0, 3, 0 ),

-:93: ERROR:SPACING: space prohibited after that open parenthesis '('
#93: FILE: drivers/gpu/drm/xe/xe_pat.c:125:
+	[26] = XE2_PAT( 0, 0, 2, 0, 3, 2 ),

-:93: ERROR:SPACING: space prohibited before that close parenthesis ')'
#93: FILE: drivers/gpu/drm/xe/xe_pat.c:125:
+	[26] = XE2_PAT( 0, 0, 2, 0, 3, 2 ),

-:94: ERROR:SPACING: space prohibited after that open parenthesis '('
#94: FILE: drivers/gpu/drm/xe/xe_pat.c:126:
+	[27] = XE2_PAT( 0, 0, 2, 0, 3, 3 ),

-:94: ERROR:SPACING: space prohibited before that close parenthesis ')'
#94: FILE: drivers/gpu/drm/xe/xe_pat.c:126:
+	[27] = XE2_PAT( 0, 0, 2, 0, 3, 3 ),

-:95: ERROR:SPACING: space prohibited after that open parenthesis '('
#95: FILE: drivers/gpu/drm/xe/xe_pat.c:127:
+	[28] = XE2_PAT( 0, 0, 3, 0, 3, 0 ),

-:95: ERROR:SPACING: space prohibited before that close parenthesis ')'
#95: FILE: drivers/gpu/drm/xe/xe_pat.c:127:
+	[28] = XE2_PAT( 0, 0, 3, 0, 3, 0 ),

-:96: ERROR:SPACING: space prohibited after that open parenthesis '('
#96: FILE: drivers/gpu/drm/xe/xe_pat.c:128:
+	[29] = XE2_PAT( 0, 1, 3, 0, 3, 0 ),

-:96: ERROR:SPACING: space prohibited before that close parenthesis ')'
#96: FILE: drivers/gpu/drm/xe/xe_pat.c:128:
+	[29] = XE2_PAT( 0, 1, 3, 0, 3, 0 ),

-:97: ERROR:SPACING: space prohibited after that open parenthesis '('
#97: FILE: drivers/gpu/drm/xe/xe_pat.c:129:
+	[30] = XE2_PAT( 0, 0, 3, 0, 3, 2 ),

-:97: ERROR:SPACING: space prohibited before that close parenthesis ')'
#97: FILE: drivers/gpu/drm/xe/xe_pat.c:129:
+	[30] = XE2_PAT( 0, 0, 3, 0, 3, 2 ),

-:98: ERROR:SPACING: space prohibited after that open parenthesis '('
#98: FILE: drivers/gpu/drm/xe/xe_pat.c:130:
+	[31] = XE2_PAT( 0, 0, 3, 0, 3, 3 ),

-:98: ERROR:SPACING: space prohibited before that close parenthesis ')'
#98: FILE: drivers/gpu/drm/xe/xe_pat.c:130:
+	[31] = XE2_PAT( 0, 0, 3, 0, 3, 3 ),

-:102: ERROR:SPACING: space prohibited after that open parenthesis '('
#102: FILE: drivers/gpu/drm/xe/xe_pat.c:134:
+#define XE2_PAT_ATS	XE2_PAT( 0, 0, 0, 0, 3, 3 )

-:102: ERROR:SPACING: space prohibited before that close parenthesis ')'
#102: FILE: drivers/gpu/drm/xe/xe_pat.c:134:
+#define XE2_PAT_ATS	XE2_PAT( 0, 0, 0, 0, 3, 3 )

total: 69 errors, 0 warnings, 0 checks, 116 lines checked
4d2687807 drm/xe/xe2: Add one more bit to encode PAT to ppgtt entries
ca58888b7 drm/xe/pat: Add debugfs node to dump PAT
3731dd046 drm/xe/gt: Dump PAT table when failing to initialize

More information about the Intel-xe mailing list