[Intel-xe] ✗ CI.checkpatch: warning for Port CPU-GPU timestamp correlation to XE KMD
Patchwork
patchwork at emeril.freedesktop.org
Tue Oct 3 18:12:20 UTC 2023
== Series Details ==
Series: Port CPU-GPU timestamp correlation to XE KMD
URL : https://patchwork.freedesktop.org/series/124565/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
63c2b6b160bca2df6efc7bc4cea6f442097d7854
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 256e295924bf5db66cb4eebe45ba2522faeca9c4
Author: Umesh Nerlige Ramappa <umesh.nerlige.ramappa at intel.com>
Date: Tue Oct 3 11:09:09 2023 -0700
drm/xe: Correlate engine and cpu timestamps with better accuracy
Perf measurements rely on CPU and engine timestamps to correlate
events of interest across these time domains. Current mechanisms get
these timestamps separately and the calculated delta between these
timestamps lack enough accuracy.
To improve the accuracy of these time measurements to within a few us,
add a query that returns the engine and cpu timestamps captured as
close to each other as possible.
Mesa MR: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24591
v2:
- Fix kernel-doc warnings (CI)
- Document input params and group them together (Jose)
- s/cs/engine/ (Jose)
- Remove padding in the query (Ashutosh)
v3:
- s/rsvd/pad/ in struct drm_xe_engine_class_instance (Jose)
- Explicitly initialize pad to 0
Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa at intel.com>
Reviewed-by: José Roberto de Souza <jose.souza at intel.com>
Signed-off-by: Francois Dugast <francois.dugast at intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
[Rodrigo finished the s/cs/engine renaming]
+ /mt/dim checkpatch 090c3e92db31fbbe59a47d44f8dd7e8a1ccbcb36 drm-intel
f46e80513 drm/xe: Fix array bounds check for queries
-:9: WARNING:UNKNOWN_COMMIT_ID: Unknown commit id '22504d560287', maybe rebased or not pulled?
#9:
Fixes: 22504d560287 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
total: 0 errors, 1 warnings, 0 checks, 8 lines checked
eaa15f299 drm/xe: Set the correct type for xe_to_user_engine_class
256e29592 drm/xe: Correlate engine and cpu timestamps with better accuracy
-:130: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#130: FILE: drivers/gpu/drm/xe/xe_query.c:108:
+query_engine_cycles(struct xe_device *xe,
+ struct drm_xe_device_query *query)
total: 0 errors, 0 warnings, 1 checks, 311 lines checked
More information about the Intel-xe
mailing list