[Intel-xe] [PATCH] fixup! drm/xe/hwmon: Expose power attributes

[Lucas De Marchi]

On Thu, Oct 05, 2023 at 10:10:11AM -0400, Rodrigo Vivi wrote:
>On Wed, Oct 04, 2023 at 12:38:11PM -0500, Lucas De Marchi wrote:
>> On Wed, Oct 04, 2023 at 05:08:05PM +0000, Kershner, David wrote:
>> > -----Original Message-----
>> > > From: Intel-xe <intel-xe-bounces at lists.freedesktop.org> On Behalf Of Rodrigo
>> > > Vivi
>> > > Sent: Wednesday, October 4, 2023 12:26 PM
>> > > To: De Marchi, Lucas <lucas.demarchi at intel.com>
>> > > Cc: intel-xe at lists.freedesktop.org
>> > > Subject: Re: [Intel-xe] [PATCH] fixup! drm/xe/hwmon: Expose power
>> > > attributes
>> > >
>> > > On Wed, Oct 04, 2023 at 09:09:32AM -0700, Lucas De Marchi wrote:
>> > > > Add missing static to fixup build with W=1
>> > >
>> > > https://lore.kernel.org/all/20231003222145.4090918-3-
>> > > david.kershner at intel.com/
>> >
>> > I'm not sure what the protocol is here, I'm still fixing up the other patch that I
>> > have in my series. Should we just drop my patch and have yours go in?
>>
>> Quick fixups like this could be sent individually so we don't depend on
>> other things to apply.
>>
>> I'd rather have this as a fixup (as in this patch) so we don't have the build
>> broken in any official release.  If 1 year from now someone is doing a
>> bisect and fall in the middle of these commits, they may have to adjust
>> their warning settings.
>
>Good point on the bisect breakage. Let's move with fixup this time.
>
>Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>

pushed, thanks
Lucas De Marchi

>
>
>>
>> And of course, we should make sure not to introduce these regressions in
>> the first place.
>>
>> Lucas De Marchi
>>
>> >
>> > David Kershner
>> >
>> > >
>> > > >
>> > > > Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
>> > > > ---
>> > > >
>> > > > Also I see in the changelog a change adding xe_ prefix to the static
>> > > > funtions... that is not the convention most of the driver follow and I
>> > > > don't think it should had been done. Anyway, just fixing the more
>> > > > immediate issue here.
>> > > >
>> > > >  drivers/gpu/drm/xe/xe_hwmon.c | 3 ++-
>> > > >  1 file changed, 2 insertions(+), 1 deletion(-)
>> > > >
>> > > > diff --git a/drivers/gpu/drm/xe/xe_hwmon.c
>> > > > b/drivers/gpu/drm/xe/xe_hwmon.c index 1deb5007e1e2..734fcca9f71f
>> > > > 100644
>> > > > --- a/drivers/gpu/drm/xe/xe_hwmon.c
>> > > > +++ b/drivers/gpu/drm/xe/xe_hwmon.c
>> > > > @@ -123,7 +123,8 @@ static int xe_hwmon_process_reg(struct xe_hwmon
>> > > *hwmon, enum xe_hwmon_reg hwmon_
>> > > >  	}
>> > > >  }
>> > > >
>> > > > -int xe_hwmon_process_reg_read64(struct xe_hwmon *hwmon, enum
>> > > > xe_hwmon_reg hwmon_reg, u64 *value)
>> > > > +static int xe_hwmon_process_reg_read64(struct xe_hwmon *hwmon,
>> > > > +				       enum xe_hwmon_reg hwmon_reg, u64
>> > > *value)
>> > > >  {
>> > > >  	struct xe_reg reg;
>> > > >
>> > > > --
>> > > > 2.40.1
>> > > >