[Intel-xe] [PATCH 3/3] drm/xe: Create a dummy version for vga decode

[Shankar, Uma]

> -----Original Message-----
> From: Murthy, Arun R <arun.r.murthy at intel.com>
> Sent: Friday, October 6, 2023 8:57 AM
> To: Shankar, Uma <uma.shankar at intel.com>; intel-xe at lists.freedesktop.org
> Cc: Nikula, Jani <jani.nikula at intel.com>
> Subject: RE: [PATCH 3/3] drm/xe: Create a dummy version for vga decode
> 
> 
> > -----Original Message-----
> > From: Shankar, Uma <uma.shankar at intel.com>
> > Sent: Thursday, October 5, 2023 7:29 PM
> > To: intel-xe at lists.freedesktop.org
> > Cc: Nikula, Jani <jani.nikula at intel.com>; Murthy, Arun R
> > <arun.r.murthy at intel.com>; Shankar, Uma <uma.shankar at intel.com>
> > Subject: [PATCH 3/3] drm/xe: Create a dummy version for vga decode
> >
> > This implements an exclusive version of vga decode for xe.
> > Rest of the display changes will be re-used from i915.
> Implementation I yet to come in the follow up patches. Here we are just adding
> the function definitions.

Yeah, will re-phrase this.

> >
> > Currently it adds just a dummy implementation. VGA decode needs to be
> > handled correctly in i915, proper implementation will be adopted once
> > the i915 changes are finalized and merged upstream.
> Merged in upstream.

Sure, will correct it.

> >
> > Signed-off-by: Uma Shankar <uma.shankar at intel.com>
> > ---
> >  drivers/gpu/drm/xe/Makefile                  |  1 +
> >  drivers/gpu/drm/xe/display/xe_display_misc.c | 13 +++++++++++++
> >  2 files changed, 14 insertions(+)
> >  create mode 100644 drivers/gpu/drm/xe/display/xe_display_misc.c
> >
> > diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile
> > index
> > dff1386ee6b3..175a357366d9 100644
> > --- a/drivers/gpu/drm/xe/Makefile
> > +++ b/drivers/gpu/drm/xe/Makefile
> > @@ -150,6 +150,7 @@ xe-$(CONFIG_DRM_XE_DISPLAY) += \
> >  	display/xe_hdcp_gsc.o \
> >  	display/xe_plane_initial.o \
> >  	display/xe_display_rps.o \
> > +	display/xe_display_misc.o \
> >  	display/ext/i915_irq.o \
> >  	display/ext/i915_utils.o
> >
> > diff --git a/drivers/gpu/drm/xe/display/xe_display_misc.c
> > b/drivers/gpu/drm/xe/display/xe_display_misc.c
> > new file mode 100644
> > index 000000000000..4f2392f911ce
> > --- /dev/null
> > +++ b/drivers/gpu/drm/xe/display/xe_display_misc.c
> > @@ -0,0 +1,13 @@
> > +// SPDX-License-Identifier: MIT
> > +/*
> > + * Copyright © 2023 Intel Corporation  */
> > +
> > +#include "intel_display_types.h"
> > +
> > +struct pci_dev;
> > +
> > +unsigned int intel_gmch_vga_set_decode(struct pci_dev *pdev, bool
> > +enable_decode) {
> Is a TODO: required over here?

Yes, will add it.

Thanks Arun for the feedback and reviews, will modify and send next version.

Regards,
Uma Shankar
 
> > +	return 0;
> > +}
> > --
> > 2.42.0
> 
> Thanks and Regards,
> Arun R Murthy
> --------------------