[Intel-xe] ✗ CI.checkpatch: warning for drm/xe: Add uapi for dumpable bos
Patchwork
patchwork at emeril.freedesktop.org
Fri Oct 6 19:38:23 UTC 2023
== Series Details ==
Series: drm/xe: Add uapi for dumpable bos
URL : https://patchwork.freedesktop.org/series/124741/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
63c2b6b160bca2df6efc7bc4cea6f442097d7854
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit dc9a5715b8f80346f846b8acde8ca403fa8db8e6
Author: Maarten Lankhorst <dev at lankhorst.se>
Date: Fri Oct 6 19:18:00 2023 +0200
drm/xe: Add uapi for dumpable bos
Add XE_GEM_CREATE_FLAG_DUMPABLE for use with VM_BIND.
For BO's with vram regions, XE_GEM_CREATE_FLAG_NEEDS_VISIBLE_VRAM
also needs to be specified.
After this, we can use the flag XE_VM_BIND_FLAG_DUMPABLE to notify
devcoredump that this mapping should be dumped.
This is not hooked up, but the uapi should be ready before merging.
If needed, we can relax the restrictions later.
It's also not yet certain whether the BO contents will be preserved,
or a reference to the BO. The latter allows us to skip a whole lot of
tricky locking. This requires userspace to destroy all bo's that were
marked dumpable though, but I feel this is a cleaner solution from
a kernel perspective.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
+ /mt/dim checkpatch d4af396a232e87d1febbc0e8832ae03bb3ecc4ea drm-intel
dc9a5715b drm/xe: Add uapi for dumpable bos
-:42: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#42: FILE: drivers/gpu/drm/xe/xe_bo.c:1816:
+ if (XE_IOCTL_DBG(xe, (bo_flags & XE_BO_CREATE_VRAM_MASK &&
+ !(bo_flags & XE_GEM_CREATE_FLAG_NEEDS_VISIBLE_VRAM))))
-:146: WARNING:TYPO_SPELLING: 'informations' may be misspelled - perhaps 'information'?
#146: FILE: include/uapi/drm/xe_drm.h:651:
+ * See the NOTE there for more informations.
^^^^^^^^^^^^
-:151: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Maarten Lankhorst <dev at lankhorst.se>' != 'Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>'
total: 0 errors, 2 warnings, 1 checks, 104 lines checked
More information about the Intel-xe
mailing list