[Intel-xe] [PATCH 1/3] fixup! FIXME: drm/i915: xe doesn't have gsc hdcp interface or something

[Shankar, Uma]

> > > -----Original Message-----
> > > From: Kandpal, Suraj <suraj.kandpal at intel.com>
> > > Sent: Friday, September 22, 2023 4:08 PM
> > > To: intel-xe at lists.freedesktop.org
> > > Cc: Shankar, Uma <uma.shankar at intel.com>; Kandpal, Suraj
> > > <suraj.kandpal at intel.com>
> > > Subject: [PATCH 1/3] fixup! FIXME: drm/i915: xe doesn't have gsc
> > > hdcp interface or something
> > >
> > > Remove stubs to clean up HDCP code
> >
> > You can mention which patch is being fixed here (one which introduced
> > the change).
> > This can later be squashed together.
> 
> So the fixup patch mentions which patch is being fixed
> FIXME: drm/i915: xe doesn't have gsc hdcp interface or something (subject the
> commit being fixed)

Yeah ok, I guess this should be enough, no need for an explicit hash.

Regards,
Uma Shankar

> Regards,
> Suraj Kandpal
> 
> >
> > > --v3
> > > -Should be a fixup patch [Jani]
> > >
> > > Signed-off-by: Suraj Kandpal <suraj.kandpal at intel.com>
> > > ---
> > >  drivers/gpu/drm/i915/display/intel_hdcp.c | 5 -----
> > >  1 file changed, 5 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c
> > > b/drivers/gpu/drm/i915/display/intel_hdcp.c
> > > index f617ccd206c8..a42549fa9691 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_hdcp.c
> > > +++ b/drivers/gpu/drm/i915/display/intel_hdcp.c
> > > @@ -174,7 +174,6 @@ bool intel_hdcp2_capable(struct intel_connector
> > > *connector)
> > >
> > >  	/* If MTL+ make sure gsc is loaded and proxy is setup */
> > >  	if (intel_hdcp_gsc_cs_required(i915)) { -#ifdef I915
> > >  		struct intel_gt *gt = i915->media_gt;
> > >  		struct intel_gsc_uc *gsc = gt ? &gt->uc.gsc : NULL;
> > >
> > > @@ -183,10 +182,6 @@ bool intel_hdcp2_capable(struct intel_connector
> > > *connector)
> > >  				    "GSC components required for HDCP2.2 are
> > not ready\n");
> > >  			return false;
> > >  		}
> > > -#else
> > > -		/* TODO */
> > > -		return false;
> > > -#endif
> > >  	}
> > >
> > >  	/* MEI/GSC interface is solid depending on which is used */
> > > --
> > > 2.25.1