[Intel-xe] ✗ CI.checkpatch: warning for drm/xe: Make DRM_XE_DEVICE_QUERY_ENGINES future proof
Patchwork
patchwork at emeril.freedesktop.org
Tue Oct 10 19:11:20 UTC 2023
== Series Details ==
Series: drm/xe: Make DRM_XE_DEVICE_QUERY_ENGINES future proof
URL : https://patchwork.freedesktop.org/series/124912/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
63c2b6b160bca2df6efc7bc4cea6f442097d7854
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit a4df0ac8b83d576c1d9bb97f993601d88a4d04ba
Author: José Roberto de Souza <jose.souza at intel.com>
Date: Tue Oct 10 07:17:43 2023 -0700
drm/xe: Make DRM_XE_DEVICE_QUERY_ENGINES future proof
We have at least 2 future features(OA and future media engines capabilities)
that will require Xe to provide more information about engines to UMDs.
But this information should not just be added to
drm_xe_engine_class_instance for a couple of reasons:
- drm_xe_engine_class_instance is used as input to other structs/uAPIs
and those uAPIs don't care about any of these future new engine fields
- those new fields are useless information after initialization for
some UMDs, so it should not need to carry that around
So here my proposal is to make DRM_XE_DEVICE_QUERY_ENGINES return an
array of drm_xe_query_engine_info that contain
drm_xe_engine_class_instance and 3 u64s to be used for future features.
Reference OA: https://patchwork.freedesktop.org/patch/558362/?series=121084&rev=6
Cc: Francois Dugast <francois.dugast at intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
Signed-off-by: José Roberto de Souza <jose.souza at intel.com>
+ /mt/dim checkpatch 37b2d042c23ae6a10055ea92101a15083d64c718 drm-intel
a4df0ac8b drm/xe: Make DRM_XE_DEVICE_QUERY_ENGINES future proof
-:9: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#9:
We have at least 2 future features(OA and future media engines capabilities)
total: 0 errors, 1 warnings, 0 checks, 96 lines checked
More information about the Intel-xe
mailing list