[Intel-xe] [PATCH 2/2] drm/xe/uapi: Multiplex PERF ops through a single PERF ioctl

Dixit, Ashutosh ashutosh.dixit at intel.com
Wed Oct 11 17:33:32 UTC 2023


On Wed, 11 Oct 2023 04:24:21 -0700, Guy Zadicario wrote:
>

Hi Guy,

>
> Replying to you only since I do not have access to my mailbox from
> text-based email client (trying to get there but IT guys runs me crazy ☹)
> I wasn't sure if reply from outlook work ok, is it?

Once in a while is ok, but if you are going to respond regularly on the
mailing list, a text based email client is preferable.

>
> The only comment I have is that enum @drm_xe_perf_op includes operations
> on a perf stream fd only and not operations on the main perf ioctl.  Do
> we want to merge both types of operations in the same enum? If so, you
> need to add to that enum operations for OPEN,ADD_CONFIG,REMOVE_CONFIG.

You are absolutely right, I missed out on adding 'enum drm_xe_perf_op'
which was there in the original OA series. I've added it in v2 and also
cleaned up the naming and some other minor changes. The perf fd ioct's are
in a separate 'enum drm_xe_perf_ioctls'.

https://patchwork.freedesktop.org/series/124994/

Thanks so much.
--
Ashutosh


More information about the Intel-xe mailing list