[Intel-xe] ✗ CI.checkpatch: warning for Xe PERF layer

Patchwork patchwork at emeril.freedesktop.org
Wed Oct 11 23:01:52 UTC 2023


== Series Details ==

Series: Xe PERF layer
URL   : https://patchwork.freedesktop.org/series/124994/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
63c2b6b160bca2df6efc7bc4cea6f442097d7854
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 1c7545a30325e8238f0df0a4fdc937a8284330dd
Author: Ashutosh Dixit <ashutosh.dixit at intel.com>
Date:   Wed Oct 11 10:26:42 2023 -0700

    drm/xe/uapi: Multiplex PERF ops through a single PERF ioctl
    
    Since we are already mulitplexing multiple perf counter stream types
    through the PERF layer, it seems odd to retain separate ioctls for perf
    op's (add/remove config). In fact it seems logical to also multiplex these
    ops through a single PERF ioctl. This also affords greater flexibility to
    add stream specific ops if needed for different perf stream types.
    
    v2: Add 'enum drm_xe_perf_op' previously missed out (Guy Zadicario)
        Add DRM_ prefix to perf op names and more consistent naming
    
    Signed-off-by: Ashutosh Dixit <ashutosh.dixit at intel.com>
+ /mt/dim checkpatch fe4d6ceb20b5ebad356c722396c2c06d4485c359 drm-intel
1441d9fbe drm/xe/uapi: "Perf" layer to support multiple perf counter stream types
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:17: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#17: 
v3: Rename 'enum drm_xe_perf_ops' to 'enum drm_xe_perf_ioctls' (Guy Zadicario)

-:57: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#57: 
new file mode 100644

-:151: WARNING:LONG_LINE: line length of 118 exceeds 100 columns
#151: FILE: include/uapi/drm/xe_drm.h:133:
+#define DRM_IOCTL_XE_PERF_OPEN			DRM_IOW(DRM_COMMAND_BASE + DRM_XE_PERF_OPEN, struct drm_xe_perf_param)

-:152: WARNING:LONG_LINE: line length of 124 exceeds 100 columns
#152: FILE: include/uapi/drm/xe_drm.h:134:
+#define DRM_IOCTL_XE_PERF_ADD_CONFIG		DRM_IOW(DRM_COMMAND_BASE + DRM_XE_PERF_ADD_CONFIG, struct drm_xe_perf_param)

-:153: WARNING:LONG_LINE: line length of 127 exceeds 100 columns
#153: FILE: include/uapi/drm/xe_drm.h:135:
+#define DRM_IOCTL_XE_PERF_REMOVE_CONFIG		DRM_IOW(DRM_COMMAND_BASE + DRM_XE_PERF_REMOVE_CONFIG, struct drm_xe_perf_param)

total: 0 errors, 5 warnings, 0 checks, 155 lines checked
1c7545a30 drm/xe/uapi: Multiplex PERF ops through a single PERF ioctl
-:107: WARNING:LONG_LINE: line length of 113 exceeds 100 columns
#107: FILE: include/uapi/drm/xe_drm.h:131:
+#define DRM_IOCTL_XE_PERF			DRM_IOW(DRM_COMMAND_BASE + DRM_XE_PERF, struct drm_xe_perf_param)

total: 0 errors, 1 warnings, 0 checks, 101 lines checked




More information about the Intel-xe mailing list