[Intel-xe] [PATCH 1/2] drm/i915: Remove the module parameter 'fastboot'

[Murthy, Arun R]

> -----Original Message-----
> From: Nikula, Jani <jani.nikula at intel.com>
> Sent: Thursday, October 12, 2023 2:37 PM
> To: Murthy, Arun R <arun.r.murthy at intel.com>; intel-xe at lists.freedesktop.org;
> Shankar, Uma <uma.shankar at intel.com>
> Cc: Murthy, Arun R <arun.r.murthy at intel.com>
> Subject: Re: [PATCH 1/2] drm/i915: Remove the module parameter 'fastboot'
> 
> On Thu, 12 Oct 2023, Arun R Murthy <arun.r.murthy at intel.com> wrote:
> > By default fastboot is enabled on all Display 9+ platforms and
> > disabled on older platforms. Its not necessary to retain this as a
> > module parameter.
> >
> > Signed-off-by: Arun R Murthy <arun.r.murthy at intel.com>
> > Link:
> > https://patchwork.freedesktop.org/patch/msgid/20230926091157.635438-1-
> > arun.r.murthy at intel.com (cherry picked from commit
> > 58883680a8416661b48a800e5530e2efcea64a4a
> > ---
> >  drivers/gpu/drm/i915/display/intel_display.c | 3 ---
> >  drivers/gpu/drm/i915/i915_params.c           | 5 -----
> >  drivers/gpu/drm/i915/i915_params.h           | 1 -
> >  3 files changed, 9 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> > b/drivers/gpu/drm/i915/display/intel_display.c
> > index 4b73db93d23d..748e9a42e94f 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display.c
> > +++ b/drivers/gpu/drm/i915/display/intel_display.c
> > @@ -4989,9 +4989,6 @@ pipe_config_mismatch(bool fastset, const struct
> > intel_crtc *crtc,  static bool fastboot_enabled(struct
> > drm_i915_private *dev_priv)  {  #ifdef I915
> > -	if (dev_priv->params.fastboot != -1)
> > -		return dev_priv->params.fastboot;
> > -
> 
> Sorry, you've got the patch order wrong. You've had to modify the backport
> which is evident from the context.
> 
> The revert goes first and the backport next. When the original patch and its
> revert get rebased away, the backport will still be intact. With this order, you
> get conflicts every step of the way, and have to be fixed, and still risk deviating
> from the upstream commit.

I was assuming that if the revert goes first then that would break the build.
Hence though of removing that variable first and then revert thereby each
individual patch builds are not broken.
Anyway will get it done this way.

> 
> Also, please post new revisions of patch series as new threads. The replies to
> threads gets confusing to both humans and CI.

In order to retain the history used in-reply-to. Will push as a new series.

Thanks and Regards,
Arun R Murthy
--------------------
> 
> BR,
> Jani.
> 
> 
> >  	/* Enable fastboot by default on Skylake and newer */
> >  	if (DISPLAY_VER(dev_priv) >= 9)
> >  		return true;
> > diff --git a/drivers/gpu/drm/i915/i915_params.c
> > b/drivers/gpu/drm/i915/i915_params.c
> > index 0a171b57fd8f..036c4c3ed6ed 100644
> > --- a/drivers/gpu/drm/i915/i915_params.c
> > +++ b/drivers/gpu/drm/i915/i915_params.c
> > @@ -137,11 +137,6 @@ i915_param_named_unsafe(enable_ips, int, 0400,
> > "Enable IPS (default: true)");  i915_param_named_unsafe(enable_dpt, bool,
> 0400,
> >  	"Enable display page table (DPT) (default: true)");
> >
> > -i915_param_named(fastboot, int, 0400,
> > -	"Try to skip unnecessary mode sets at boot time "
> > -	"(0=disabled, 1=enabled) "
> > -	"Default: -1 (use per-chip default)");
> > -
> >  i915_param_named_unsafe(load_detect_test, bool, 0400,
> >  	"Force-enable the VGA load detect code for testing (default:false). "
> >  	"For developers only.");
> > diff --git a/drivers/gpu/drm/i915/i915_params.h
> > b/drivers/gpu/drm/i915/i915_params.h
> > index 68abf0ad6c00..d5194b039aab 100644
> > --- a/drivers/gpu/drm/i915/i915_params.h
> > +++ b/drivers/gpu/drm/i915/i915_params.h
> > @@ -72,7 +72,6 @@ struct drm_printer;
> >  	param(int, edp_vswing, 0, 0400) \
> >  	param(unsigned int, reset, 3, 0600) \
> >  	param(unsigned int, inject_probe_failure, 0, 0) \
> > -	param(int, fastboot, -1, 0600) \
> >  	param(int, enable_dpcd_backlight, -1, 0600) \
> >  	param(char *, force_probe, CONFIG_DRM_I915_FORCE_PROBE, 0400) \
> >  	param(unsigned int, request_timeout_ms,
> > CONFIG_DRM_I915_REQUEST_TIMEOUT,
> CONFIG_DRM_I915_REQUEST_TIMEOUT ?
> > 0600 : 0) \
> 
> --
> Jani Nikula, Intel