[Intel-xe] [PATCH 6/6] fixup! drm/xe/display: Implement display support

Lucas De Marchi lucas.demarchi at intel.com
Thu Oct 12 16:50:07 UTC 2023


On Thu, Oct 12, 2023 at 06:24:10PM +0530, Chaitanya Kumar Borah wrote:
>Add definition for INTEL_UC_FIRMWARE_URL to maintain compatibility
>with intel_dmc code.
>
>Signed-off-by: Chaitanya Kumar Borah <chaitanya.kumar.borah at intel.com>
>---
> drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h    |  1 +
> drivers/gpu/drm/xe/compat-i915-headers/intel_uc_fw.h | 11 +++++++++++
> 2 files changed, 12 insertions(+)
> create mode 100644 drivers/gpu/drm/xe/compat-i915-headers/intel_uc_fw.h
>
>diff --git a/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h b/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h
>index 9cbe16863be2..4e922446e40e 100644
>--- a/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h
>+++ b/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h
>@@ -22,6 +22,7 @@
> #include "i915_utils.h"
> #include "intel_gt_types.h"
> #include "intel_step.h"
>+#include "intel_uc_fw.h"
> #include "intel_uncore.h"
> #include "intel_runtime_pm.h"
> #include <linux/pm_runtime.h>
>diff --git a/drivers/gpu/drm/xe/compat-i915-headers/intel_uc_fw.h b/drivers/gpu/drm/xe/compat-i915-headers/intel_uc_fw.h
>new file mode 100644
>index 000000000000..7d37bc453165
>--- /dev/null
>+++ b/drivers/gpu/drm/xe/compat-i915-headers/intel_uc_fw.h
>@@ -0,0 +1,11 @@
>+/* SPDX-License-Identifier: MIT */
>+/*
>+ * Copyright © 2023 Intel Corporation
>+ */
>+
>+#ifndef _INTEL_UC_FW_H_
>+#define _INTEL_UC_FW_H_
>+
>+#define INTEL_UC_FIRMWARE_URL "https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/i915"

that may not be the right URL for xe. For any platform officially
supported by xe driver, the expectation is that the firmware will be in
the xe/ directory. I'd rather just point to the repo like we are
currently doing:

drivers/gpu/drm/xe/xe_uc_fw.h:#define XE_UC_FIRMWARE_URL "https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git"


Lucas De Marchi

>+
>+#endif
>-- 
>2.25.1
>


More information about the Intel-xe mailing list