[Intel-xe] ✗ CI.checkpatch: warning for LRC debugfs and general instruction tweaks (rev2)

[Patchwork]

== Series Details ==

Series: LRC debugfs and general instruction tweaks (rev2)
URL   : https://patchwork.freedesktop.org/series/125008/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
63c2b6b160bca2df6efc7bc4cea6f442097d7854
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 35af4701f7ef446c98a98f03777a732e1a9fbc5c
Author: Matt Roper <matthew.d.roper at intel.com>
Date:   Wed Oct 11 16:10:04 2023 -0700

    drm/xe/debugfs: Include GFXPIPE commands in LRC dump
    
    RCS and CCS engines include several non-register gfxpipe commands in
    their LRC images.  Include these in the dump output so that we can see
    exactly what's inside the context snapshot.
    
    Signed-off-by: Matt Roper <matthew.d.roper at intel.com>
+ /mt/dim checkpatch 6c0d1e36f310682297a5b07336b0883afc77f66e drm-intel
43834bf0e drm/xe: Make MI_FLUSH_DW immediate size more explicit
b20eeb3a8 drm/xe: Separate number of registers from MI_LRI opcode
c2a553548 drm/xe: Clarify number of dwords/qwords stored by MI_STORE_DATA_IMM
d11b497f1 drm/xe: Extract MI_* instructions to their own header
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:18: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#18: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 190 lines checked
70f54e2b8 drm/xe/debugfs: Add dump of default LRCs' MI instructions
-:61: ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#61: FILE: drivers/gpu/drm/xe/xe_gt_debugfs.c:153:
+static int rcs_default_lrc(struct seq_file *m, void *data) {

-:68: ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#68: FILE: drivers/gpu/drm/xe/xe_gt_debugfs.c:160:
+static int ccs_default_lrc(struct seq_file *m, void *data) {

-:75: ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#75: FILE: drivers/gpu/drm/xe/xe_gt_debugfs.c:167:
+static int bcs_default_lrc(struct seq_file *m, void *data) {

-:82: ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#82: FILE: drivers/gpu/drm/xe/xe_gt_debugfs.c:174:
+static int vcs_default_lrc(struct seq_file *m, void *data) {

-:89: ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#89: FILE: drivers/gpu/drm/xe/xe_gt_debugfs.c:181:
+static int vecs_default_lrc(struct seq_file *m, void *data) {

-:145: WARNING:LINE_SPACING: Missing a blank line after declarations
#145: FILE: drivers/gpu/drm/xe/xe_lrc.c:925:
+		int num_noop = 1;
+		while (num_noop < remaining_dw &&

total: 5 errors, 1 warnings, 0 checks, 183 lines checked
35af4701f drm/xe/debugfs: Include GFXPIPE commands in LRC dump
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:13: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#13: 
new file mode 100644

-:62: CHECK:LINE_SPACING: Please don't use multiple blank lines
#62: FILE: drivers/gpu/drm/xe/instructions/xe_gfxpipe_commands.h:45:
+
+

-:160: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#160: FILE: drivers/gpu/drm/xe/xe_lrc.c:976:
+	switch (*dw & GFXPIPE_MATCH_MASK) {
+

-:161: WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#161: FILE: drivers/gpu/drm/xe/xe_lrc.c:977:
+#define MATCH(cmd) \
+	case cmd: \
+		  drm_printf(p, #cmd " (%d dwords)\n", numdw); \
+		return numdw

total: 0 errors, 2 warnings, 2 checks, 224 lines checked