[Intel-xe] ✗ CI.checkpatch: warning for drm/xe: Update to upstream DRM scheduler code

Patchwork patchwork at emeril.freedesktop.org
Wed Oct 25 04:11:54 UTC 2023


== Series Details ==

Series: drm/xe: Update to upstream DRM scheduler code
URL   : https://patchwork.freedesktop.org/series/125540/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
63c2b6b160bca2df6efc7bc4cea6f442097d7854
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 672549977619a1ab7cd54fa168f24c9ec2bbe8fc
Author: Matthew Brost <matthew.brost at intel.com>
Date:   Tue Oct 24 21:05:20 2023 -0700

    drm/xe: Update to upstream DRM scheduler code
    
    The largest change is the message interface has been removed from the
    DRM scheduler. Xe still needs a message interface so it is implemented
    in the Xe driver by adding a Xe scheduler layer.
    
    Signed-off-by: Matthew Brost <matthew.brost at intel.com>
+ /mt/dim checkpatch 4354e27efb78582ee567ba6264c79d0872a3a4e7 drm-intel
672549977 drm/xe: Update to upstream DRM scheduler code
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:496: WARNING:LONG_LINE: line length of 202 exceeds 100 columns
#496: FILE: drivers/gpu/drm/scheduler/sched_main.c:75:
+MODULE_PARM_DESC(sched_policy, "Specify the scheduling policy for entities on a run-queue, " __stringify(DRM_SCHED_POLICY_RR) " = Round Robin, " __stringify(DRM_SCHED_POLICY_FIFO) " = FIFO (default).");

-:1096: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1096: FILE: drivers/gpu/drm/scheduler/sched_main.c:1156:
+		   u32 num_rqs, unsigned hw_submission, unsigned hang_limit,

-:1096: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1096: FILE: drivers/gpu/drm/scheduler/sched_main.c:1156:
+		   u32 num_rqs, unsigned hw_submission, unsigned hang_limit,

-:1156: WARNING:OOM_MESSAGE: Possible unnecessary 'out of memory' message
#1156: FILE: drivers/gpu/drm/scheduler/sched_main.c:1199:
+	if (!sched->sched_rq) {
+		drm_err(sched, "%s: out of memory for sched_rq\n", __func__);

-:1164: CHECK:CAMELCASE: Avoid CamelCase: <Out_unroll>
#1164: FILE: drivers/gpu/drm/scheduler/sched_main.c:1207:
+			goto Out_unroll;

-:1426: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#1426: 
new file mode 100644

-:1491: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1491: FILE: drivers/gpu/drm/xe/xe_gpu_scheduler.c:61:
+		  uint32_t hw_submission, unsigned hang_limit,

-:1491: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u32' over 'uint32_t'
#1491: FILE: drivers/gpu/drm/xe/xe_gpu_scheduler.c:61:
+		  uint32_t hw_submission, unsigned hang_limit,

-:1553: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1553: FILE: drivers/gpu/drm/xe/xe_gpu_scheduler.h:16:
+		  uint32_t hw_submission, unsigned hang_limit,

-:1553: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u32' over 'uint32_t'
#1553: FILE: drivers/gpu/drm/xe/xe_gpu_scheduler.h:16:
+		  uint32_t hw_submission, unsigned hang_limit,

-:1959: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1959: FILE: drivers/gpu/drm/xe/xe_guc_submit.c:1170:
+	err = xe_sched_init(&ge->sched, &drm_sched_ops, &xe_sched_ops, NULL,
 			     q->lrc[0].ring.size / MAX_JOB_SIZE_BYTES,

-:2413: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#2413: FILE: include/drm/gpu_scheduler.h:533:
+		   u32 num_rqs, uint32_t hw_submission, unsigned hang_limit,

total: 0 errors, 8 warnings, 4 checks, 2218 lines checked




More information about the Intel-xe mailing list