[Intel-xe] [PATCH 01/10] revert fixme in intel_atomic_plane.c
Maarten Lankhorst
maarten.lankhorst at linux.intel.com
Wed Oct 25 10:20:36 UTC 2023
Revert the plane_fb changes, so we can fix it properly.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
---
.../gpu/drm/i915/display/intel_atomic_plane.c | 25 +++----------------
1 file changed, 4 insertions(+), 21 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_atomic_plane.c b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
index 62b6108c43808..dd65498166fbf 100644
--- a/drivers/gpu/drm/i915/display/intel_atomic_plane.c
+++ b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
@@ -1033,11 +1033,10 @@ static int
intel_prepare_plane_fb(struct drm_plane *_plane,
struct drm_plane_state *_new_plane_state)
{
- struct intel_plane_state *new_plane_state =
- to_intel_plane_state(_new_plane_state);
-#ifdef I915
struct i915_sched_attr attr = { .priority = I915_PRIORITY_DISPLAY };
struct intel_plane *plane = to_intel_plane(_plane);
+ struct intel_plane_state *new_plane_state =
+ to_intel_plane_state(_new_plane_state);
struct intel_atomic_state *state =
to_intel_atomic_state(new_plane_state->uapi.state);
struct drm_i915_private *dev_priv = to_i915(plane->base.dev);
@@ -1133,22 +1132,6 @@ intel_prepare_plane_fb(struct drm_plane *_plane,
intel_plane_unpin_fb(new_plane_state);
return ret;
-#else
- int ret;
-
- if (!intel_fb_obj(new_plane_state->hw.fb))
- return 0;
-
- ret = intel_plane_pin_fb(new_plane_state);
- if (ret)
- return ret;
-
- ret = drm_gem_plane_helper_prepare_fb(_plane, _new_plane_state);
- if (ret)
- intel_plane_unpin_fb(new_plane_state);
-
- return ret;
-#endif
}
/**
@@ -1164,9 +1147,9 @@ intel_cleanup_plane_fb(struct drm_plane *plane,
{
struct intel_plane_state *old_plane_state =
to_intel_plane_state(_old_plane_state);
- __maybe_unused struct intel_atomic_state *state =
+ struct intel_atomic_state *state =
to_intel_atomic_state(old_plane_state->uapi.state);
- __maybe_unused struct drm_i915_private *dev_priv = to_i915(plane->dev);
+ struct drm_i915_private *dev_priv = to_i915(plane->dev);
struct drm_i915_gem_object *obj = intel_fb_obj(old_plane_state->hw.fb);
if (!obj)
--
2.39.2
More information about the Intel-xe
mailing list