[Intel-xe] ✗ CI.checkpatch: warning for Reduce usage of xe_tile in xe_bo.c
Patchwork
patchwork at emeril.freedesktop.org
Wed Oct 25 21:47:37 UTC 2023
== Series Details ==
Series: Reduce usage of xe_tile in xe_bo.c
URL : https://patchwork.freedesktop.org/series/125593/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
63c2b6b160bca2df6efc7bc4cea6f442097d7854
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 3f29e5a33f6376166a64264818d50456574fe248
Author: Brian Welty <brian.welty at intel.com>
Date: Wed Oct 25 11:00:08 2023 -0700
drm/xe: Replace usage of mem_type_to_tile
Currently mem_type_to_tile() is being used to access the tile's underlying
tile.mem.vram. However, this function makes the assumption that a mem_type
will only ever map to a single tile. Now that the TTM vram manager contains
a pointer to the memory_region, make use of this in xe_bo.c.
As such, introduce a helper function res_to_mem_region() to get the
ttm_vram_mgr->vram from the BO's resource, and use this to replace usage
of mem_type_to_tile().
xe_tile is still needed to choose the migration context, so this part is
unchanged. But as this is only renaming usage, function is renamed now to
mem_type_to_migrate().
Signed-off-by: Brian Welty <brian.welty at intel.com>
+ /mt/dim checkpatch bd3d7e8aa312ce25c5797388f753151f024bec02 drm-intel
7d9e2abe6 drm/xe: Replace xe_ttm_vram_mgr.tile with xe_mem_region
-:10: WARNING:TYPO_SPELLING: 'unneccesary' may be misspelled - perhaps 'unnecessary'?
#10:
unneccesary usage of xe_tile from xe_bo.c in later patch.
^^^^^^^^^^^
total: 0 errors, 1 warnings, 0 checks, 37 lines checked
bad15680a drm/xe: Remove unused xe_bo_to_tile
3f29e5a33 drm/xe: Replace usage of mem_type_to_tile
More information about the Intel-xe
mailing list