[Intel-xe] [PATCH v2 3/3] drm/xe: Add Wa_14019821291
Lucas De Marchi
lucas.demarchi at intel.com
Thu Oct 26 15:55:57 UTC 2023
On Thu, Oct 26, 2023 at 11:10:14AM -0300, Gustavo Sousa wrote:
>>@@ -37,7 +37,7 @@ quiet_cmd_wa_oob = GEN $(notdir $(generated_oob))
>> $(generated_oob) &: $(obj)/xe_gen_wa_oob $(srctree)/$(src)/xe_wa_oob.rules
>> $(call cmd,wa_oob)
>>
>>-$(obj)/xe_guc.o $(obj)/xe_migrate.o $(obj)/xe_ring_ops.o $(obj)/xe_vm.o $(obj)/xe_wa.o: $(generated_oob)
>>+$(obj)/xe_guc.o $(obj)/xe_migrate.o $(obj)/xe_ring_ops.o $(obj)/xe_vm.o $(obj)/xe_wa.o $(obj)/xe_ttm_stolen_mgr.o: $(generated_oob)
>
>Nitpick: It seems the list of targets is sorted. Maybe we should keep it
>that way.
>
>On an unrelated note, I wonder if there is a way to have the dependency
>on the header automatically detected.
I tried a few times, but I was always hitting some issues and builds
failing as I increased the concurrency level. Just tried again with the
simplest possible solution:
%.o: $(generated_oob)
It passes on incremental builds when I touch xe_wa_oob.rules, but fails
on a clean build. I hope to get this removed soon, but I don't want to
block any patch just adding new files here.
Lucas De Marchi
More information about the Intel-xe
mailing list