[Intel-xe] [PATCH 31/31] fixup! drm/xe/display: Implement display support

Jouni Högander jouni.hogander at intel.com
Fri Oct 27 07:59:18 UTC 2023


We can remove all display parameters from xe params as they are all
now available in xe_device->display->params.

Signed-off-by: Jouni Högander <jouni.hogander at intel.com>
---
 drivers/gpu/drm/xe/xe_device_types.h | 22 ----------------------
 drivers/gpu/drm/xe/xe_display.c      | 13 -------------
 2 files changed, 35 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_device_types.h b/drivers/gpu/drm/xe/xe_device_types.h
index 44d622d4cc3a..cb537cac1ef9 100644
--- a/drivers/gpu/drm/xe/xe_device_types.h
+++ b/drivers/gpu/drm/xe/xe_device_types.h
@@ -474,30 +474,8 @@ struct xe_device {
 		unsigned int fsb_freq, mem_freq, is_ddr3;
 		u8 vblank_enabled;
 	};
-
 	struct {
-		/* Backlight: XXX: needs to be set to -1 */
-		s32 invert_brightness;
-		s32 vbt_sdvo_panel_type;
-		u32 edp_vswing;
-
-		/* PM support, needs to be -1 as well */
-		s32 disable_power_well;
-		s32 enable_dc;
-
 		const char *dmc_firmware_path;
-		s32 enable_dpcd_backlight;
-		s32 enable_dp_mst;
-		bool enable_dpt;
-		s32 enable_fbc;
-		s32 enable_psr;
-		bool enable_sagv;
-		bool psr_safest_params;
-		s32 enable_psr2_sel_fetch;
-
-		s32 panel_use_ssc;
-		const char *vbt_firmware;
-		u32 lvds_channel_mode;
 	} params;
 #endif
 };
diff --git a/drivers/gpu/drm/xe/xe_display.c b/drivers/gpu/drm/xe/xe_display.c
index 77c71c7612ce..da10f16e1c12 100644
--- a/drivers/gpu/drm/xe/xe_display.c
+++ b/drivers/gpu/drm/xe/xe_display.c
@@ -115,19 +115,6 @@ int xe_display_create(struct xe_device *xe)
 	drmm_mutex_init(&xe->drm, &xe->display.hdcp.hdcp_mutex);
 	xe->enabled_irq_mask = ~0;
 
-	xe->params.invert_brightness = -1;
-	xe->params.vbt_sdvo_panel_type = -1;
-	xe->params.disable_power_well = -1;
-	xe->params.enable_dc = -1;
-	xe->params.enable_dpcd_backlight = -1;
-	xe->params.enable_dp_mst = -1;
-	xe->params.enable_dpt = true;
-	xe->params.enable_fbc = -1;
-	xe->params.enable_psr = -1;
-	xe->params.enable_psr2_sel_fetch = -1;
-	xe->params.enable_sagv = true;
-	xe->params.panel_use_ssc = -1;
-
 	err = drmm_add_action_or_reset(&xe->drm, display_destroy, NULL);
 	if (err)
 		return err;
-- 
2.34.1



More information about the Intel-xe mailing list