[Intel-xe] ✗ CI.checkpatch: warning for Some eviction fixes (rev2)

Patchwork patchwork at emeril.freedesktop.org
Fri Oct 27 11:17:30 UTC 2023


== Series Details ==

Series: Some eviction fixes (rev2)
URL   : https://patchwork.freedesktop.org/series/125591/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
63c2b6b160bca2df6efc7bc4cea6f442097d7854
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 226c0818ddc35bc3bd27e9cbd7ea468e46bb2485
Author: Matthew Auld <matthew.auld at intel.com>
Date:   Fri Oct 27 11:48:14 2023 +0100

    drm/xe/bo: sync kernel fences for KMD buffers
    
    With things like pipelined evictions, VRAM pages can be marked as free
    and yet still have some active kernel fences, with the idea that the
    next caller to allocate the memory will respect them. However it looks
    like we are missing synchronisation for KMD internal buffers, like
    page-tables, lrc etc. For userspace objects we should already have the
    required synchronisation for CPU access via the fault handler, and
    likewise for GPU access when vm_binding them.
    
    To fix this synchronise against any kernel fences for all KMD objects at
    creation. This should resolve some severe corruption seen during
    evictions.
    
    v2 (Matt B):
      - Revamp the comment explaining this. Also mention why USAGE_KERNEL is
        correct here.
    
    Closes: ?
    Testcase: igt at xe-evict-ccs
    Reported-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
    Signed-off-by: Matthew Auld <matthew.auld at intel.com>
    Cc: Thomas Hellström <thomas.hellstrom at linux.intel.com>
    Cc: Matthew Brost <matthew.brost at intel.com>
+ /mt/dim checkpatch 76d7314ce7ceb58ee595a0ae1ba45bc99b9e277d drm-intel
80c8a89c9 drm/xe/migrate: fix MI_ARB_ON_OFF usage
365ee677e drm/xe/bo: consider dma-resv fences for clear job
226c0818d drm/xe/bo: sync kernel fences for KMD buffers
-:25: WARNING:COMMIT_LOG_WRONG_LINK: 'Closes:' should be followed by a public http(s) link
#25: 
Closes: ?

-:27: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be immediately followed by Closes: with a URL to the report
#27: 
Reported-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
Signed-off-by: Matthew Auld <matthew.auld at intel.com>

total: 0 errors, 2 warnings, 0 checks, 27 lines checked




More information about the Intel-xe mailing list