[Intel-xe] ✗ CI.checkpatch: warning for drm/xe: Add mocs kunit (rev6)

Patchwork patchwork at emeril.freedesktop.org
Mon Oct 30 18:50:11 UTC 2023


== Series Details ==

Series: drm/xe: Add mocs kunit (rev6)
URL   : https://patchwork.freedesktop.org/series/124926/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
63c2b6b160bca2df6efc7bc4cea6f442097d7854
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit f259cb14e3745678406c06e02e8a86de9185a51a
Author: Ruthuvikas Ravikumar <ruthuvikas.ravikumar at intel.com>
Date:   Mon Oct 30 23:25:22 2023 +0530

    drm/xe: Add mocs kunit
    
    This kunit verifies the hardware values of mocs and
    l3cc registers with the KMD programmed values.
    
    v6: Change ssize_t type.
        Change forcewake domain to XE_FW_GT.
        Update change of MOCS registers are multicast on Xe_HP and beyond
        patch.
    
    v5: Release forcewake.
        Remove single statement braces.
        Fix debug statements.
    
    v4: Drop stratch and vaddr.
        Fix debug statements.
        Fix indentation.
    
    v3: Fix checkpath.
    
    v2: Fix checkpath.
    
    Cc: Aravind Iddamsetty <aravind.iddamsetty at intel.com>
    Cc: Mathew D Roper <matthew.d.roper at intel.com>
    Signed-off-by: Ruthuvikas Ravikumar <ruthuvikas.ravikumar at intel.com>
+ /mt/dim checkpatch 1e652bcf7cc139244f4f8c0cd1fc184029240050 drm-intel
f259cb14e drm/xe: Add mocs kunit
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:43: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#43: 
new file mode 100644

-:119: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#119: FILE: drivers/gpu/drm/xe/tests/xe_mocs.c:72:
+			mocs_dbg(&gt_to_xe(gt)->drm, "%d 0x%x 0x%x 0x%x\n", i, reg_mcr.__reg.addr,
+			 reg_val, l3cc);

-:122: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#122: FILE: drivers/gpu/drm/xe/tests/xe_mocs.c:75:
+				KUNIT_FAIL(test, "l3cc reg 0x%x has incorrect val.\n",
+					reg_mcr.__reg.addr);

-:124: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#124: FILE: drivers/gpu/drm/xe/tests/xe_mocs.c:77:
+		}
+		else {

-:124: CHECK:BRACES: Unbalanced braces around else statement
#124: FILE: drivers/gpu/drm/xe/tests/xe_mocs.c:77:
+		else {

-:129: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#129: FILE: drivers/gpu/drm/xe/tests/xe_mocs.c:82:
+			mocs_dbg(&gt_to_xe(gt)->drm, "%d 0x%x 0x%x 0x%x\n", i, reg.addr,
+			 reg_val, l3cc);

-:132: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#132: FILE: drivers/gpu/drm/xe/tests/xe_mocs.c:85:
+				KUNIT_FAIL(test, "l3cc reg 0x%x has incorrect val.\n",
+				   reg.addr);

-:135: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#135: FILE: drivers/gpu/drm/xe/tests/xe_mocs.c:88:
+
+	}

-:137: WARNING:INDENTED_LABEL: labels should not be indented
#137: FILE: drivers/gpu/drm/xe/tests/xe_mocs.c:90:
+	out:

-:142: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#142: FILE: drivers/gpu/drm/xe/tests/xe_mocs.c:95:
+static void read_mocs_table(struct xe_gt *gt,
+			      const struct xe_mocs_info *info)

-:164: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#164: FILE: drivers/gpu/drm/xe/tests/xe_mocs.c:117:
+	     i++) {
+

-:170: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#170: FILE: drivers/gpu/drm/xe/tests/xe_mocs.c:123:
+			mocs_dbg(&gt_to_xe(gt)->drm, "%d 0x%x 0x%x 0x%x\n", i,
+			 reg_mcr.__reg.addr, reg_val, mocs);

-:173: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#173: FILE: drivers/gpu/drm/xe/tests/xe_mocs.c:126:
+				KUNIT_FAIL(test, "mocs reg 0x%x has incorrect val:\n",
+					reg_mcr.__reg.addr);

-:175: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#175: FILE: drivers/gpu/drm/xe/tests/xe_mocs.c:128:
+		}
+		else {

-:175: CHECK:BRACES: Unbalanced braces around else statement
#175: FILE: drivers/gpu/drm/xe/tests/xe_mocs.c:128:
+		else {

-:180: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#180: FILE: drivers/gpu/drm/xe/tests/xe_mocs.c:133:
+			mocs_dbg(&gt_to_xe(gt)->drm, "%d 0x%x 0x%x 0x%x\n", i,
+			 reg.addr, reg_val, mocs);

-:183: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#183: FILE: drivers/gpu/drm/xe/tests/xe_mocs.c:136:
+				KUNIT_FAIL(test, "mocs reg 0x%x has incorrect val:\n",
+				   reg.addr);

-:187: WARNING:INDENTED_LABEL: labels should not be indented
#187: FILE: drivers/gpu/drm/xe/tests/xe_mocs.c:140:
+	out:

total: 2 errors, 3 warnings, 13 checks, 218 lines checked




More information about the Intel-xe mailing list