[Intel-xe] [PATCH] drm/xe/display: Print display ip version

[Lucas De Marchi]

On Wed, Sep 06, 2023 at 11:04:57AM -0700, Matt Roper wrote:
>On Wed, Sep 06, 2023 at 11:34:00AM +0530, Balasubramani Vivekanandan wrote:
>> Print display ip version during module load
>>
>> Signed-off-by: Balasubramani Vivekanandan <balasubramani.vivekanandan at intel.com>
>> ---
>>  drivers/gpu/drm/xe/xe_pci.c | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
>> index 60f3474844e2..fc01544346d5 100644
>> --- a/drivers/gpu/drm/xe/xe_pci.c
>> +++ b/drivers/gpu/drm/xe/xe_pci.c
>> @@ -844,6 +844,11 @@ static int xe_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>>  		str_yes_no(xe->info.enable_display),
>>  		xe->info.dma_mask_size, xe->info.tile_count);
>>
>> +	if (xe->info.enable_display)
>> +		drm_dbg(&xe->drm, "Display: %d.%02d\n",
>> +			xe->info.display_runtime.ip.ver,
>> +			xe->info.display_runtime.ip.rel);
>> +
>
>Rather than printing the display version here, it might be better to
>call intel_display_device_info_print() somewhere appropriate which will

Somewhere appropriate would be xe_display.c, so it only gets printed if
there is display.... or if it's moved to a shared function in i915
itself that we already call.

Lucas De Marchi

>dump not only the IP version, but also the relevant feature flags.
>
>
>Matt
>
>>  	drm_dbg(&xe->drm, "Stepping = (G:%s, M:%s, D:%s, B:%s)\n",
>>  		xe_step_name(xe->info.step.graphics),
>>  		xe_step_name(xe->info.step.media),
>> --
>> 2.25.1
>>
>
>-- 
>Matt Roper
>Graphics Software Engineer
>Linux GPU Platform Enablement
>Intel Corporation