[Intel-xe] [Intel-gfx] [PATCH v2 01/27] drm/i915/xelpdp: Add XE_LPDP_FEATURES

[Lucas De Marchi]

On Thu, Sep 07, 2023 at 09:04:03AM -0700, Matt Roper wrote:
>On Thu, Sep 07, 2023 at 08:37:31AM -0700, Lucas De Marchi wrote:
>> Add a FEATURES macro for XE_LPD+ as this is expected to be the baseline
>> for Xe2_LPD and will allow to see the delta more easily.
>
>Would it be simpler to do
>
>        #define XE_LPDP_FEATURES \
>                XE_LPD_FEATURES \
>                /* additional deltas */
>
>so that it's more obvious what the deltas between Xe_LPD -> Xe_LPD+ are
>too?


remember the nightmare we had in i915 with multiple inheritance? In the
end we settled to have just one level - the struct has 1 _FEATURES and
overrides or set new fields. A _FEATURES is always the root, without
inheriting from others.

It may be more verbose, but it's easier to look for "is x enabled in
this platform?"

Lucas De Marchi