[Intel-xe] [PATCH 01/10] drm/xe/oa: Introduce OA uapi

[Dixit, Ashutosh]

On Thu, 31 Aug 2023 12:55:14 -0700, Vivi, Rodrigo wrote:
>

Rodrigo/Francois,

> On Tue, Aug 22, 2023 at 10:31:06AM +0200, Francois Dugast wrote:
> > Hi Ashutosh,
> >
> > On Mon, Aug 07, 2023 at 06:31:50PM -0700, Ashutosh Dixit wrote:
> > > OA uapi allows userspace to:
> > > * Read streams of performance counters written by hardware
> > > * Configure (and reconfigure) which sets of perf counters are captured as
> > >   part of OA streams
> > > * Configure other properties (such as format and periodicity) of such
> > >   captures.
> > > * Query associated parameters such as OA unit timestamp freq, oa_unit_id's
> > >   for hw engines and OA ioctl version
> >
> > Also it would be nice to explicit somewhere what OA stands for, maybe
> > in the commit message as well.

I've added what OA stands for to the commit message of Patch 1.

https://patchwork.freedesktop.org/series/121084/#rev5

> > Please document the uapi structures, not only their members.

>
> Besides that, we need true API like documentation with examples showing
> how this is used. Please!

We are rapidly changing the OA uapi. uapi changes will be reviewed
(including UMD's) and accepted or rejected. I will add such documentation
after the uapi is close to being frozen.

Thanks.
--
Ashutosh