[Intel-xe] [PATCH 1/1] fixup! drm/xe/display: Implement display support

Gustavo Sousa gustavo.sousa at intel.com
Fri Sep 8 18:49:28 UTC 2023


In Xe initialization path, the function intel_init_display_hooks() is
being called twice, which is redundant. To remove redundancy, let's
remove one of the calls.

That function sets up hooks that are called from: (i) later in the
initialization path (i.e. intel_display_driver_probe_nogem()), (ii)
resume, or (iii) mode set commits.

In both call sites, none of the scenarios above are reached yet, so it
would be safe to remove the redundant call from either of the two.
However, since intel_display_driver_early_probe() is shared by both i915
and Xe, prefer to remove the call done from xe_display_init_nommio().

Signed-off-by: Gustavo Sousa <gustavo.sousa at intel.com>
---
 drivers/gpu/drm/xe/xe_display.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_display.c b/drivers/gpu/drm/xe/xe_display.c
index a453946ad108..5823e3f2de1c 100644
--- a/drivers/gpu/drm/xe/xe_display.c
+++ b/drivers/gpu/drm/xe/xe_display.c
@@ -159,8 +159,6 @@ int xe_display_init_nommio(struct xe_device *xe)
 	if (err)
 		return err;
 
-	intel_init_display_hooks(xe);
-
 	return drmm_add_action_or_reset(&xe->drm, xe_display_fini_nommio, xe);
 }
 
-- 
2.41.0



More information about the Intel-xe mailing list