[Intel-xe] [PATCH] drm/xe/uapi: Use common drm_xe_ext_set_property extension

[Dixit, Ashutosh]

On Sat, 09 Sep 2023 08:21:59 -0700, Rodrigo Vivi wrote:
>

Hi Rodrigo,

> On Sat, Sep 09, 2023 at 11:15:20AM -0400, Rodrigo Vivi wrote:
> > On Fri, Sep 08, 2023 at 10:21:53PM -0700, Ashutosh Dixit wrote:
> > > There really is no difference between 'struct drm_xe_ext_vm_set_property'
> > > and 'struct drm_xe_ext_exec_queue_set_property', they are extensions which
> > > specify a <property, value> pair. Replace the two extensions with a single
> > > common 'struct drm_xe_ext_set_property' extension. The rationale is that
> > > rather than have each XE module (including future modules) invent their own
> > > property/value extensions, all XE modules use a common set_property
> > > extension when possible.
> >
> > What about just killing this entirely?
> > https://lore.kernel.org/all/20230908203302.449041-2-rodrigo.vivi@intel.com/
>
> hmm... or maybe what we want is a mix of your patch and mine.
> Let's use yours to kill the drm_xe_ext_exec_queue_set_property
> in favor of a generic drm_xe_ext_set_property
> and then mine goes on top killing just the
> XE_VM_PROPERTY_BIND_OP_ERROR_CAPTURE_ADDRESS operation.
>
> thoughts? I can integrate and carry your patch in my series if you are
> okay with that.

Yes, please go ahead. Fwiw I think a generic drm_xe_ext_set_property will
be useful in the future, e.g. I am thinking of using it for OA.

Thanks.
--
Ashutosh