[Intel-xe] ✗ CI.checkpatch: warning for Use Xe assert macros instead of XE_WARN_ON macro (rev5)

Patchwork patchwork at emeril.freedesktop.org
Tue Sep 12 21:54:44 UTC 2023


== Series Details ==

Series: Use Xe assert macros instead of XE_WARN_ON macro (rev5)
URL   : https://patchwork.freedesktop.org/series/122906/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
63c2b6b160bca2df6efc7bc4cea6f442097d7854
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit f3ba3cdbfc64efc6d2706361855064bdb1916782
Author: Francois Dugast <francois.dugast at intel.com>
Date:   Tue Sep 12 19:59:45 2023 +0000

    drm/xe: Use Xe assert macros instead of XE_WARN_ON macro
    
    The XE_WARN_ON macro maps to WARN_ON which is not justified
    in many cases where only a simple debug check is needed.
    Replace the use of the XE_WARN_ON macro with the new xe_assert
    macros which relies on drm_*. This takes a struct drm_device
    argument, which is one of the main changes in this commit. The
    other main change is that the condition is reversed, as with
    XE_WARN_ON a message is displayed if the condition is true,
    whereas with xe_assert it is if the condition is false.
    
    v2:
    - Rebase
    - Keep WARN splats in xe_wopcm.c (Matt Roper)
    
    v3:
    - Rebase
    
    Signed-off-by: Francois Dugast <francois.dugast at intel.com>
    Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
+ /mt/dim checkpatch da184d0771450c366fa6499d42b49eba733a67f8 drm-intel
6ffd2c5c5 drm/xe: Replace XE_WARN_ON with drm_warn when just printing a string
38d4ffc37 drm/xe: Introduce Xe assert macros
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:40: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#40: 
[ ] WARNING: CPU: 0 PID: 2687 at drivers/gpu/drm/xe/xe_device.c:281 xe_device_probe+0x374/0x520 [xe]

-:71: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#71: 
new file mode 100644

total: 0 errors, 2 warnings, 0 checks, 177 lines checked
f3ba3cdbf drm/xe: Use Xe assert macros instead of XE_WARN_ON macro




More information about the Intel-xe mailing list