[Intel-xe] ✗ CI.checkpatch: warning for uC management cleanup (rev2)

Patchwork patchwork at emeril.freedesktop.org
Thu Sep 14 00:01:26 UTC 2023


== Series Details ==

Series: uC management cleanup (rev2)
URL   : https://patchwork.freedesktop.org/series/123654/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
63c2b6b160bca2df6efc7bc4cea6f442097d7854
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit eda98c656d3222157868949d9abb3a1a4720bd41
Author: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
Date:   Wed Sep 13 16:28:37 2023 -0700

    drm/xe/uc: Add GuC/HuC firmware path overrides
    
    When testing a new binary and/or debugging binary-related issues, it is
    useful to have the option to change which binary is loaded without
    having to update and re-compile the kernel. To support this option, this
    patch adds 2 new modparams to override the FW path for GuC and HuC. The
    HuC modparam can also be set to an empty string to disable HuC loading.
    
    Note that those modparams only take effect on platforms where we already
    have a default FW, so we're sure there is support for FW loading and the
    kernel isn't going to explode in an undefined path.
    
    v2: simplify comment (John),
        rebase on s/guc_submission_enabled/uc_enabled
    
    Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
    Cc: John Harrison <John.C.Harrison at Intel.com>
    Cc: Matthew Brost <matthew.brost at intel.com>
    Reviewed-by: John Harrison <John.C.Harrison at Intel.com>
+ /mt/dim checkpatch 89b671db4d8e2c46f27044d39c69095f597290e5 drm-intel
33d42d870 drm/xe/uc: Rename guc_submission_enabled() to uc_enabled()
ba15e29b4 drm/xe/uc: Fix uC status tracking
eda98c656 drm/xe/uc: Add GuC/HuC firmware path overrides
-:32: ERROR:GLOBAL_INITIALISERS: do not initialise globals to NULL
#32: FILE: drivers/gpu/drm/xe/xe_module.c:33:
+char *xe_guc_firmware_path = NULL;

-:37: ERROR:GLOBAL_INITIALISERS: do not initialise globals to NULL
#37: FILE: drivers/gpu/drm/xe/xe_module.c:38:
+char *xe_huc_firmware_path = NULL;

total: 2 errors, 0 warnings, 0 checks, 70 lines checked




More information about the Intel-xe mailing list