[Intel-xe] [RFC PATCH] drm/xe/display: Select some missing configs

Maarten Lankhorst maarten.lankhorst at linux.intel.com
Mon Sep 18 14:17:39 UTC 2023



On 2023-09-15 20:06, Thomas Hellström wrote:
> When selecting CONFIG_XE_DISPLAY, the following missing symbols can be
> seen unless something else has selected the corresponding configs.
> 
> ERROR: modpost: "cfb_copyarea" [drivers/gpu/drm/xe/xe.ko] undefined!
> ERROR: modpost: "cfb_fillrect" [drivers/gpu/drm/xe/xe.ko] undefined!
> ERROR: modpost: "cfb_imageblit" [drivers/gpu/drm/xe/xe.ko] undefined
> 
> Make sure these are included in the Xe Display build.
> 
> Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
> Signed-off-by: Thomas Hellström <thomas.hellstrom at linux.intel.com>
> ---
>   drivers/gpu/drm/xe/Kconfig | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/xe/Kconfig
> index 096bd066afa8..ed2dd73f153b 100644
> --- a/drivers/gpu/drm/xe/Kconfig
> +++ b/drivers/gpu/drm/xe/Kconfig
> @@ -45,6 +45,9 @@ config DRM_XE
>   config DRM_XE_DISPLAY
>   	bool "Enable display support"
>   	depends on DRM_XE && EXPERT
> +	select FB_CFB_COPYAREA
> +	select FB_CFB_FILLRECT
> +	select FB_CFB_IMAGEBLIT
>   	select I2C
>   	select I2C_ALGOBIT
>   	default y
Make that FB_IOMEM_HELPERS, and you can add my r-b. :-)

Reviewed-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>


More information about the Intel-xe mailing list