[Intel-xe] ✗ CI.checkpatch: warning for Some changes for Xe in spinlock handling in i915/display
Patchwork
patchwork at emeril.freedesktop.org
Tue Sep 19 10:06:08 UTC 2023
== Series Details ==
Series: Some changes for Xe in spinlock handling in i915/display
URL : https://patchwork.freedesktop.org/series/123899/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
63c2b6b160bca2df6efc7bc4cea6f442097d7854
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 25fc1d79c60cb80074969c192d2fdd1e3321f249
Author: Luca Coelho <luciano.coelho at intel.com>
Date: Tue Sep 19 12:47:37 2023 +0300
drm/i915: handle uncore spinlock when not available
The uncore code may not always be available (e.g. when we build the
display code with Xe), so we can't always rely on having the uncore's
spinlock.
To handle this, split the spin_lock/unlock_irqsave/restore() into
spin_lock/unlock() followed by a call to local_irq_save/restore() and
create wrapper functions for locking and unlocking the uncore's
spinlock. In these functions, we have a condition check and only
actually try to lock/unlock the spinlock when I915 is defined, and
thus uncore is available.
This keeps the ifdefs contained in these new functions and all such
logic inside the display code.
Signed-off-by: Luca Coelho <luciano.coelho at intel.com>
+ /mt/dim checkpatch 3d7e02fb9c40263a989c4c19d2dc5a07659965ed drm-intel
4e14993f4 Revert "FIXME: drm/i915/crtc: use irqsave for locking event_lock"
-:7: WARNING:UNKNOWN_COMMIT_ID: Unknown commit id '0aff77c2fbd20da430763bdb25db5eaa6245650a', maybe rebased or not pulled?
#7:
This reverts commit 0aff77c2fbd20da430763bdb25db5eaa6245650a.
total: 0 errors, 1 warnings, 0 checks, 17 lines checked
25fc1d79c drm/i915: handle uncore spinlock when not available
More information about the Intel-xe
mailing list