[Intel-xe] ✗ CI.checkpatch: warning for DRM scheduler update

Patchwork patchwork at emeril.freedesktop.org
Thu Sep 21 00:47:18 UTC 2023


== Series Details ==

Series: DRM scheduler update
URL   : https://patchwork.freedesktop.org/series/124021/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
63c2b6b160bca2df6efc7bc4cea6f442097d7854
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit a2422354c17d0397fd8445a171c061a270bb5f0f
Author: Matthew Brost <matthew.brost at intel.com>
Date:   Wed Sep 20 16:19:42 2023 -0700

    drm/xe: Update to upstream DRM scheduler code
    
    The largest change is the message interface has been removed from the
    DRM scheduler. Xe still needs a message interface so it is implemented
    in the Xe driver by adding a Xe scheduler layer.
    
    Signed-off-by: Matthew Brost <matthew.brost at intel.com>
+ /mt/dim checkpatch 6e4a4aa0279d8de30726606ccf74de109af20e6c drm-intel
a2422354c drm/xe: Update to upstream DRM scheduler code
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:202: WARNING:LONG_LINE: line length of 202 exceeds 100 columns
#202: FILE: drivers/gpu/drm/scheduler/sched_main.c:93:
+MODULE_PARM_DESC(sched_policy, "Specify the scheduling policy for entities on a run-queue, " __stringify(DRM_SCHED_POLICY_RR) " = Round Robin, " __stringify(DRM_SCHED_POLICY_FIFO) " = FIFO (default).");

-:768: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#768: FILE: drivers/gpu/drm/scheduler/sched_main.c:1169:
+			DRM_DEV_ERROR(sched->dev, "fence add callback failed (%d)\n",
+				  r);

-:879: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#879: FILE: drivers/gpu/drm/scheduler/sched_main.c:1360:
+
+}

-:969: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#969: 
new file mode 100644

-:1034: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1034: FILE: drivers/gpu/drm/xe/xe_gpu_scheduler.c:61:
+		  uint32_t hw_submission, unsigned hang_limit,

-:1034: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u32' over 'uint32_t'
#1034: FILE: drivers/gpu/drm/xe/xe_gpu_scheduler.c:61:
+		  uint32_t hw_submission, unsigned hang_limit,

-:1097: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1097: FILE: drivers/gpu/drm/xe/xe_gpu_scheduler.h:16:
+		  uint32_t hw_submission, unsigned hang_limit,

-:1097: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u32' over 'uint32_t'
#1097: FILE: drivers/gpu/drm/xe/xe_gpu_scheduler.h:16:
+		  uint32_t hw_submission, unsigned hang_limit,

-:1505: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1505: FILE: drivers/gpu/drm/xe/xe_guc_submit.c:1169:
+	err = xe_sched_init(&ge->sched, &drm_sched_ops, &xe_sched_ops, NULL,
 			     q->lrc[0].ring.size / MAX_JOB_SIZE_BYTES,

total: 0 errors, 4 warnings, 5 checks, 1717 lines checked




More information about the Intel-xe mailing list