[Intel-xe] [PATCH 3/4] fixup! drm/xe: Introduce a new DRM driver for Intel GPUs
Hogander, Jouni
jouni.hogander at intel.com
Thu Sep 21 11:15:57 UTC 2023
On Wed, 2023-09-20 at 16:02 -0400, Rodrigo Vivi wrote:
> On Mon, Sep 18, 2023 at 10:00:59AM +0300, Jouni Högander wrote:
> > intel_runtime_pm is ok for Xe driver as well. Especially as this
> > whole struct is here just to kill some build problems.
>
> I'm not sure if I like this. git grep intel_runtime_pm and you will
> understand.
>
> But also you made me thing now... we should probably simply remove
> this line from this original patch. And then only introduce back
> on the display patch.
>
> And in anyway I'd prefer some define in the compat-headers,
> rather then in here.
Thank you Rodrigo for checking my patch. Please check new version I
just sent.
BR,
Jouni Högander
>
> >
> > Signed-off-by: Jouni Högander <jouni.hogander at intel.com>
> > ---
> > drivers/gpu/drm/xe/xe_device_types.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/xe/xe_device_types.h
> > b/drivers/gpu/drm/xe/xe_device_types.h
> > index a82f28c6a3a0..ae18097cf8ea 100644
> > --- a/drivers/gpu/drm/xe/xe_device_types.h
> > +++ b/drivers/gpu/drm/xe/xe_device_types.h
> > @@ -402,7 +402,7 @@ struct xe_device {
> > u32 edram_size_mb;
> >
> > /* To shut up runtime pm macros.. */
> > - struct xe_runtime_pm {} runtime_pm;
> > + struct intel_runtime_pm {} runtime_pm;
> >
> > /* For pcode */
> > struct mutex sb_lock;
> > --
> > 2.34.1
> >
More information about the Intel-xe
mailing list