[Intel-xe] [PATCH 1/2] drm/xe: Add module parameter 'fastboot'

[Murthy, Arun R]

> -----Original Message-----
> From: Jani Nikula <jani.nikula at linux.intel.com>
> Sent: Monday, September 25, 2023 4:59 PM
> To: Shankar, Uma <uma.shankar at intel.com>; Murthy, Arun R
> <arun.r.murthy at intel.com>; intel-xe at lists.freedesktop.org
> Cc: Murthy, Arun R <arun.r.murthy at intel.com>
> Subject: Re: [Intel-xe] [PATCH 1/2] drm/xe: Add module parameter 'fastboot'
> 
> On Mon, 25 Sep 2023, "Shankar, Uma" <uma.shankar at intel.com> wrote:
> >> -----Original Message-----
> >> From: Intel-xe <intel-xe-bounces at lists.freedesktop.org> On Behalf Of
> >> Arun R Murthy
> >> Sent: Sunday, September 24, 2023 8:18 PM
> >> To: intel-xe at lists.freedesktop.org
> >> Cc: Murthy, Arun R <arun.r.murthy at intel.com>
> >> Subject: [Intel-xe] [PATCH 1/2] drm/xe: Add module parameter 'fastboot'
> >>
> >> Fastboot is by default enabled on all Display 9+ platforms.
> >> Module param is added in xe for controlling the same.
> >
> > On Xe, we don't have the module param yet. So, there is no way to
> > change the default what we set here in this patch as of now. We should
> > modify the statement here.
> >
> > It should be ok to get rid of the #define and have fastboot disabled
> > by default for now. But we should work on the task to get the module
> > param or any other mechanism acceptable by maintainers to control
> > fastboot feature.
> 
> The question is, do we *want* that module parameter in xe?
> 
I feel its not required, by default have it as enabled for all Gen 9+ platforms.

Thanks and Regards,
Arun R Murthy
--------------------


> BR,
> Jani.
> 
> 
> 
> >
> > Regards,
> > Uma Shankar
> >
> >> Signed-off-by: Arun R Murthy <arun.r.murthy at intel.com>
> >> ---
> >>  drivers/gpu/drm/xe/xe_device_types.h | 1 +
> >>  drivers/gpu/drm/xe/xe_display.c      | 1 +
> >>  2 files changed, 2 insertions(+)
> >>
> >> diff --git a/drivers/gpu/drm/xe/xe_device_types.h
> >> b/drivers/gpu/drm/xe/xe_device_types.h
> >> index a82f28c6a3a0..f73c0672bd54 100644
> >> --- a/drivers/gpu/drm/xe/xe_device_types.h
> >> +++ b/drivers/gpu/drm/xe/xe_device_types.h
> >> @@ -458,6 +458,7 @@ struct xe_device {
> >>  		s32 panel_use_ssc;
> >>  		const char *vbt_firmware;
> >>  		u32 lvds_channel_mode;
> >> +		int fastboot;
> >>  	} params;
> >>  #endif
> >>  };
> >> diff --git a/drivers/gpu/drm/xe/xe_display.c
> >> b/drivers/gpu/drm/xe/xe_display.c index bb4938a84f47..8a80d85eb104
> >> 100644
> >> --- a/drivers/gpu/drm/xe/xe_display.c
> >> +++ b/drivers/gpu/drm/xe/xe_display.c
> >> @@ -123,6 +123,7 @@ int xe_display_create(struct xe_device *xe)
> >>  	xe->params.enable_psr2_sel_fetch = -1;
> >>  	xe->params.enable_sagv = true;
> >>  	xe->params.panel_use_ssc = -1;
> >> +	xe->params.fastboot = -1;
> >>
> >>  	err = drmm_add_action_or_reset(&xe->drm, display_destroy, NULL);
> >>  	if (err)
> >> --
> >> 2.25.1
> >
> 
> --
> Jani Nikula, Intel