[Intel-xe] [PATCH v3 02/12] drm/i915: Ignore set frontbuffer return value on release

[Jani Nikula]

On Tue, 12 Sep 2023, Jouni Högander <jouni.hogander at intel.com> wrote:
> i915_gem_object_set_frontbuffer returns set frontbuffer pointer.
> When we are releasing frontbuffer we are clearing the pointer from
> the object and the value can be ignored.

Was this supposed to be sent to upstream i915? What's the story? It
depends on "remaining changes to make xe compile", and the subsequent
patches that are fixups to that, won't apply without this. So it's a bit
of a mess now. :/

J.

>
> Signed-off-by: Jouni Högander <jouni.hogander at intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_frontbuffer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_frontbuffer.c b/drivers/gpu/drm/i915/display/intel_frontbuffer.c
> index a9a8c75b8236..629185e5a880 100644
> --- a/drivers/gpu/drm/i915/display/intel_frontbuffer.c
> +++ b/drivers/gpu/drm/i915/display/intel_frontbuffer.c
> @@ -238,7 +238,7 @@ static void frontbuffer_release(struct kref *ref)
>  #ifdef I915
>  	i915_ggtt_clear_scanout(obj);
>  
> -	i915_gem_object_set_frontbuffer(obj, NULL);
> +	(void) i915_gem_object_set_frontbuffer(obj, NULL);
>  #endif
>  	spin_unlock(&intel_bo_to_i915(obj)->display.fb_tracking.lock);

-- 
Jani Nikula, Intel