[Intel-xe] [PATCH 2/3] drm/xe/vm: use list_last_entry() to fetch last_op

Niranjana Vishwanathapura niranjana.vishwanathapura at intel.com
Sat Sep 30 05:22:14 UTC 2023


On Fri, Sep 29, 2023 at 10:31:03AM -0700, Paulo Zanoni wrote:
>I would imagine that it's more efficient to fetch ops_list->prev than
>to walk the whole list forward.
>
>Signed-off-by: Paulo Zanoni <paulo.r.zanoni at intel.com>
>---
> drivers/gpu/drm/xe/xe_vm.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
>index e72380cc832e..68bb70b471cf 100644
>--- a/drivers/gpu/drm/xe/xe_vm.c
>+++ b/drivers/gpu/drm/xe/xe_vm.c
>@@ -3117,8 +3117,7 @@ static int vm_bind_ioctl_ops_execute(struct xe_vm *vm,
>
> 	lockdep_assert_held_write(&vm->lock);
>
>-	list_for_each_entry(op, ops_list, link)
>-		last_op = op;
>+	last_op = list_last_entry(ops_list, struct xe_vma_op, link);

Reviewed-by: Niranjana Vishwanathapura <niranjana.vishwanathapura at intel.com>

>
> 	if (!async) {
> 		err = xe_vma_op_execute(vm, last_op);
>-- 
>2.39.2
>


More information about the Intel-xe mailing list