[PATCH 10/11] drm/xe/xe2hpg: Introduce performance tuning changes for Xe2_HPG.

[Matt Roper]

On Tue, Apr 02, 2024 at 06:17:23PM +0530, Balasubramani Vivekanandan wrote:
> From: Shekhar Chauhan <shekhar.chauhan at intel.com>
> 
> Introduces performance tuning guide changes for Xe_HPG.
> 
> BSpec: 72161
> Signed-off-by: Shekhar Chauhan <shekhar.chauhan at intel.com>
> Signed-off-by: Balasubramani Vivekanandan <balasubramani.vivekanandan at intel.com>
> ---
>  drivers/gpu/drm/xe/xe_tuning.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_tuning.c b/drivers/gpu/drm/xe/xe_tuning.c
> index bb6db2817ada..d02492cb0fe8 100644
> --- a/drivers/gpu/drm/xe/xe_tuning.c
> +++ b/drivers/gpu/drm/xe/xe_tuning.c
> @@ -28,7 +28,7 @@ static const struct xe_rtp_entry_sr gt_tunings[] = {
>  	/* Xe2 */
>  
>  	{ XE_RTP_NAME("Tuning: L3 cache"),
> -	  XE_RTP_RULES(GRAPHICS_VERSION(2004)),
> +	  XE_RTP_RULES(GRAPHICS_VERSION_RANGE(2001, 2004)),

We might want to just take the opportunity now to switch this over to an
open upper bound (XE_RTP_END_VERSION_UNDEFINED) as we already have for
the other tuning settings below.  For now it's simplest to assume future
platforms will continue to use the same tuning.

Aside from that,

Reviewed-by: Matt Roper <matthew.d.roper at intel.com>


Matt

>  	  XE_RTP_ACTIONS(FIELD_SET(XEHP_L3SQCREG5, L3_PWM_TIMER_INIT_VAL_MASK,
>  				   REG_FIELD_PREP(L3_PWM_TIMER_INIT_VAL_MASK, 0x7f)))
>  	},
> @@ -38,11 +38,11 @@ static const struct xe_rtp_entry_sr gt_tunings[] = {
>  				   REG_FIELD_PREP(L3_PWM_TIMER_INIT_VAL_MASK, 0x7f)))
>  	},
>  	{ XE_RTP_NAME("Tuning: Compression Overfetch"),
> -	  XE_RTP_RULES(GRAPHICS_VERSION_RANGE(2004, XE_RTP_END_VERSION_UNDEFINED)),
> +	  XE_RTP_RULES(GRAPHICS_VERSION_RANGE(2001, XE_RTP_END_VERSION_UNDEFINED)),
>  	  XE_RTP_ACTIONS(CLR(CCCHKNREG1, ENCOMPPERFFIX)),
>  	},
>  	{ XE_RTP_NAME("Tuning: Enable compressible partial write overfetch in L3"),
> -	  XE_RTP_RULES(GRAPHICS_VERSION_RANGE(2004, XE_RTP_END_VERSION_UNDEFINED)),
> +	  XE_RTP_RULES(GRAPHICS_VERSION_RANGE(2001, XE_RTP_END_VERSION_UNDEFINED)),
>  	  XE_RTP_ACTIONS(SET(L3SQCREG3, COMPPWOVERFETCHEN))
>  	},
>  	{}
> -- 
> 2.25.1
> 

-- 
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation