[PATCH v2 02/25] drm/xe/bmg: Add BMG platform definition

Lucas De Marchi lucas.demarchi at intel.com
Wed Apr 3 13:16:01 UTC 2024


On Wed, Apr 03, 2024 at 04:52:30PM +0530, Balasubramani Vivekanandan wrote:
>diff --git a/include/drm/xe_pciids.h b/include/drm/xe_pciids.h
>index c7fc288dacee..73d972a8aca1 100644
>--- a/include/drm/xe_pciids.h
>+++ b/include/drm/xe_pciids.h
>@@ -208,4 +208,11 @@
> 	MACRO__(0x64A0, ## __VA_ARGS__), \
> 	MACRO__(0x64B0, ## __VA_ARGS__)
>
>+#define XE_BMG_IDS(MACRO__, ...) \
>+	MACRO__(0xE202, ## __VA_ARGS__), \
>+	MACRO__(0xE20B, ## __VA_ARGS__), \
>+	MACRO__(0xE20C, ## __VA_ARGS__), \
>+	MACRO__(0xE20D, ## __VA_ARGS__), \
>+	MACRO__(0xE212, ## __VA_ARGS__)

see my previous review. I don't think these patches are split correctly.
We should postpone the PCI additions and let this one be only about
adding the platform descriptor and definitions. The next patch adding
IS_BATTLEMAGE() could be squashed in this one, while the PCI additions
be separate in another patch.

Lucas De Marchi


More information about the Intel-xe mailing list