[PATCH v2 1/3] drm/xe: Use ordered wq for preempt fence waiting

Lucas De Marchi lucas.demarchi at intel.com
Wed Apr 3 14:13:06 UTC 2024


On Tue, Apr 02, 2024 at 12:14:55AM -0500, Lucas De Marchi wrote:
>On Mon, Apr 01, 2024 at 03:19:11PM -0700, Matthew Brost wrote:
>>Preempt fences can sleep waiting for an exec queue suspend operation to
>>complete. If the system_unbound_wq is used for waiting and the number of
>>waiters exceeds max_active this will result in other users of the
>>system_unbound_wq getting starved. Use a device private work queue for
>>preempt fences to avoid starvation of the system_unbound_wq.
>>
>>Even though suspend operations can complete out-of-order, all suspend
>>operations within a VM need to complete before the preempt rebind worker
>>can start. With that, use a device private ordered wq for preempt fence
>>waiting.
>>
>>v2:
>>- Add comment about cleanup on failure (Matt R)
>>- Update commit message (Lucas)
>>
>>Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
>>Signed-off-by: Matthew Brost <matthew.brost at intel.com>
>
>
>Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>

I went ahead and pushed this one so we can queue it for drm-xe-fixes.

thanks
Lucas De Marchi

>
>thanks
>Lucas De Marchi


More information about the Intel-xe mailing list