[PATCH v5 1/4] drm/xe: Define XE_REG_IS_VALID

[Nilawar, Badal]

On 04-04-2024 09:24, Karthik Poosa wrote:
> Add macro to check if struct xe_reg has valid address. (Lucas, Badal).
Usually we don't add (reviewer names) in top level commit message. You 
can use Cc: or Suggested-by: which ever appropriate.
> 
> Signed-off-by: Karthik Poosa <karthik.poosa at intel.com>
> ---
>   drivers/gpu/drm/xe/regs/xe_reg_defs.h | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/regs/xe_reg_defs.h b/drivers/gpu/drm/xe/regs/xe_reg_defs.h
> index c89ef2b79a3f..42078643be6b 100644
> --- a/drivers/gpu/drm/xe/regs/xe_reg_defs.h
> +++ b/drivers/gpu/drm/xe/regs/xe_reg_defs.h
> @@ -131,4 +131,6 @@ struct xe_reg_mcr {
>   				 .__reg = XE_REG_INITIALIZER(r_,  ##__VA_ARGS__, .mcr = 1)	\
>   				 })
>   
> +#define XE_REG_IS_VALID(r)	((r.addr) ? true : false)
Looks good to me. Please maintain this RB if you float new revisions. 
Reviewed-by: Badal Nilawar <badal.nilawar at intel.com>
> +
>   #endif