✗ CI.checkpatch: warning for drm/xe/hwmon: Update xe hwmon with couple of fixes (rev5)

Patchwork patchwork at emeril.freedesktop.org
Thu Apr 4 04:48:26 UTC 2024


== Series Details ==

Series: drm/xe/hwmon: Update xe hwmon with couple of fixes (rev5)
URL   : https://patchwork.freedesktop.org/series/131765/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
10b531c2aeb176a1a539b4a77216232f97719cec
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit dc8197989237d75b9b6968adb90193e5aa82cfaa
Author: Karthik Poosa <karthik.poosa at intel.com>
Date:   Thu Apr 4 09:24:41 2024 +0530

    drm/xe/hwmon: Cast to output precision before multiplying operands
    
    Address potential overflow in result of multiplication of two lower
    precision (u32) operands before widening it to higher precision (u64).
    
    Signed-off-by: Karthik Poosa <karthik.poosa at intel.com>
+ /mt/dim checkpatch 406e10d886a22211d2866bfa9322aec1727171f8 drm-intel
be77226caa89 drm/xe: Define XE_REG_IS_VALID
2969cf3236d2 drm/xe/hwmon: Update xe_hwmon_get_reg to return struct xe_reg
243da8e61638 drm/xe/hwmon: Update xe_hwmon_process_reg
-:25: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#25: FILE: drivers/gpu/drm/xe/xe_hwmon.c:125:
+static u64 xe_hwmon_process_reg(struct xe_hwmon *hwmon, enum xe_hwmon_reg hwmon_reg,
+				 enum xe_hwmon_reg_operation operation,

-:81: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#81: FILE: drivers/gpu/drm/xe/xe_hwmon.c:197:
+		reg_val = xe_hwmon_process_reg(hwmon, REG_PKG_RAPL_LIMIT, REG_RMW32,
 				     PKG_PWR_LIM_1_EN, 0, channel);

-:84: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#84: FILE: drivers/gpu/drm/xe/xe_hwmon.c:199:
+		reg_val = xe_hwmon_process_reg(hwmon, REG_PKG_RAPL_LIMIT, REG_READ32,
 				     PKG_PWR_LIM_1_EN, 0, channel);

-:93: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#93: FILE: drivers/gpu/drm/xe/xe_hwmon.c:212:
+	reg_val = xe_hwmon_process_reg(hwmon, REG_PKG_RAPL_LIMIT, REG_RMW32,
 			     PKG_PWR_LIM_1_EN | PKG_PWR_LIM_1, reg_val, channel);

-:112: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#112: FILE: drivers/gpu/drm/xe/xe_hwmon.c:254:
+	reg_val = xe_hwmon_process_reg(hwmon, REG_PKG_ENERGY_STATUS, REG_READ32,
+			     0, 0, channel);

-:123: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#123: FILE: drivers/gpu/drm/xe/xe_hwmon.c:281:
+	r = xe_hwmon_process_reg(hwmon, REG_PKG_RAPL_LIMIT,
+			     REG_READ32, 0, 0, sensor_index);

-:133: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#133: FILE: drivers/gpu/drm/xe/xe_hwmon.c:370:
+	r = xe_hwmon_process_reg(hwmon, REG_PKG_RAPL_LIMIT, REG_RMW32,
 			     PKG_PWR_LIM_1_TIME, rxy, sensor_index);

-:143: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#143: FILE: drivers/gpu/drm/xe/xe_hwmon.c:486:
+	reg_val = xe_hwmon_process_reg(hwmon, REG_GT_PERF_STATUS,
+			     REG_READ32, 0, 0, channel);

-:154: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#154: FILE: drivers/gpu/drm/xe/xe_hwmon.c:772:
+		val_sku_unit = xe_hwmon_process_reg(hwmon, REG_PKG_POWER_SKU_UNIT,
+				     REG_READ32, 0, 0, 0);

total: 0 errors, 0 warnings, 9 checks, 129 lines checked
dc8197989237 drm/xe/hwmon: Cast to output precision before multiplying operands




More information about the Intel-xe mailing list