[PATCH 2/2] drm/xe/guc: Reuse code while debugging GuC params

[Lucas De Marchi]

On Thu, Apr 04, 2024 at 04:41:07PM +0200, Michal Wajdeczko wrote:
>There is no need to duplicate code to print GuC parameters.
>
>Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
>---
> drivers/gpu/drm/xe/xe_guc.c | 29 +++++++++++++++--------------
> 1 file changed, 15 insertions(+), 14 deletions(-)
>
>diff --git a/drivers/gpu/drm/xe/xe_guc.c b/drivers/gpu/drm/xe/xe_guc.c
>index afb083c7cbfa..17041c9257bf 100644
>--- a/drivers/gpu/drm/xe/xe_guc.c
>+++ b/drivers/gpu/drm/xe/xe_guc.c
>@@ -180,14 +180,22 @@ static u32 guc_ctl_devid(struct xe_guc *guc)
> 	return (((u32)xe->info.devid) << 16) | xe->info.revid;
> }
>
>+static void guc_dbg_params(struct xe_guc *guc)

dbg here is a little confusing IMO as it's not clear this is printing to
the kernel log. Maybe just rename this to guc_print_params() or
guc_dump_params(). Feel free to carry my r-b:


Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>

thanks
Lucas De Marchi